Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2842833003: Update SupportsUserData uses with unique_ptr. (Closed)

Created:
3 years, 8 months ago by Avi (use Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, nasko+codewatch_chromium.org, danakj+watch_chromium.org, melevin+watch_chromium.org, sebsg+autofillwatch_chromium.org, tbansal+watch-data-reduction-proxy_chromium.org, mlamouri+watch-content_chromium.org, subresource-filter-reviews_chromium.org, ntp-dev+reviews_chromium.org, Randy Smith (Not in Mondays), petewil+watch_chromium.org, media-router+watch_chromium.org, pam+watch_chromium.org, avayvod+watch_chromium.org, chili+watch_chromium.org, David Black, mac-reviews_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, isheriff+watch_chromium.org, pfeldman, dominickn+watch_chromium.org, vmpstr+watch_chromium.org, tburkard+watch_chromium.org, noyau+watch_chromium.org, kinuko+watch, jdonnelly+watch_chromium.org, jam, loading-reviews_chromium.org, chromium-apps-reviews_chromium.org, creis+watch_chromium.org, extensions-reviews_chromium.org, nhiroki, timvolodine, asvitkine+watch_chromium.org, Jered, shimazu+serviceworker_chromium.org, gavinp+prer_chromium.org, serviceworker-reviews, loading-reviews+metrics_chromium.org, dewittj+watch_chromium.org, mmenke, samarth+watch_chromium.org, horo+watch_chromium.org, vakh+watch_chromium.org, browser-components-watch_chromium.org, msramek+watch_chromium.org, yzshen+watch_chromium.org, net-reviews_chromium.org, miu+watch_chromium.org, jsbell+serviceworker_chromium.org, fgorski+watch_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, darin-cc_chromium.org, devtools-reviews_chromium.org, xjz+watch_chromium.org, blink-worker-reviews_chromium.org, imcheng+watch_chromium.org, rouslan+autofill_chromium.org, jasonroberts+watch_google.com, csharrison+watch_chromium.org, jfweitz+watch_chromium.org, sync-reviews_chromium.org, David Trainor- moved to gerrit, donnd+watch_chromium.org, Aaron Boodman, erickung+watch_chromium.org, skanuj+watch_chromium.org, qsr+mojo_chromium.org, tzik, rogerm+autofillwatch_chromium.org, apacible+watch_chromium.org, ajwong+watch_chromium.org, markusheintz_, dimich+watch_chromium.org, cbentzel+watch_chromium.org, grt+watch_chromium.org, pkotwicz+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, speed-metrics-reviews_chromium.org, feature-media-reviews_chromium.org, kmadhusu+watch_chromium.org, gcasto+watchlist_chromium.org, zpeng+watch_chromium.org, michaeln, romax+watch_chromium.org, mathp+autofillwatch_chromium.org, kinuko+serviceworker, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update SupportsUserData uses with unique_ptr. BUG=690937 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : rev #

Patch Set 4 : rev #

Patch Set 5 : rev #

Patch Set 6 : rev #

Patch Set 7 : rev #

Patch Set 8 : rev #

Patch Set 9 : fix #

Patch Set 10 : rev #

Patch Set 11 : rev #

Patch Set 12 : rev #

Patch Set 13 : rev #

Patch Set 14 : rev #

Patch Set 15 : rebase, rev #

Patch Set 16 : rev #

Patch Set 17 : rev #

Patch Set 18 : rev #

Patch Set 19 : rebase #

Patch Set 20 : rebase #

Patch Set 21 : rebase #

Patch Set 22 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -119 lines) Patch
M base/supports_user_data.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/supports_user_data.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend_factory.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/banners/app_banner_manager_desktop.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/data_usage/tab_id_annotator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/data_use_measurement/data_use_web_contents_observer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/font_family_cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/infobars/infobar_service.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/loader/chrome_navigation_data.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/media/cast_remoting_connector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media/cast_remoting_connector.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/router/receiver_presentation_service_delegate_impl.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/metrics/renderer_uptime_web_contents_observer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/net/nss_context_chromeos.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ntp_snippets/bookmark_last_visit_updater.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/metrics_web_contents_observer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_manager_test_base.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/search/instant_io_context.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_error_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_error_handler.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_interstitial.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_interstitial.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/sessions/sync_sessions_router_tab_helper.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/tracing/navigation_tracing.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_data.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/data_use_measurement/core/data_use_measurement.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/data_use_measurement/core/data_use_measurement_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/data_use_measurement/core/data_use_network_delegate_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/feature_engagement_tracker/internal/android/feature_engagement_tracker_impl_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +3 lines, -1 line 0 comments Download
M components/guest_view/browser/guest_view_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/navigation_interception/intercept_navigation_delegate.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/offline_items_collection/core/android/offline_content_aggregator_bridge.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +3 lines, -2 lines 0 comments Download
M components/password_manager/content/browser/content_password_manager_driver_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/pdf/browser/pdf_web_contents_helper.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/pdf/browser/pdf_web_contents_helper.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/renderer_context_menu/context_menu_delegate.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/safe_browsing/base_ui_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/sessions/content/content_live_tab.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/ios/ios_live_tab.mm View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +5 lines, -3 lines 0 comments Download
M components/user_prefs/user_prefs.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/user_prefs/user_prefs.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/zoom/zoom_event_manager.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/android/context_selection_client.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/android/java/gin_java_bridge_message_filter.cc View 1 2 3 4 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/blob_storage/chrome_blob_storage_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_context.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/session/media_session_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/session/media_session_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/site_instance_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +1 line, -1 line 0 comments Download
M content/browser/websockets/websocket_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -1 line 0 comments Download
M content/public/browser/web_contents_user_data.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/internal_document_state_data.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/renderer/internal_document_state_data.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/mojo_bindings_controller.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/test/web_contents_observer_sanity_checker.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/test/web_contents_observer_sanity_checker.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M gin/modules/module_registry.cc View 2 chunks +2 lines, -1 line 0 comments Download
M storage/browser/blob/blob_url_request_job_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/web_dialogs/web_dialog_ui.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 77 (77 generated)
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-26 03:30:55 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/1
3 years, 8 months ago (2017-04-26 03:31:29 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-26 03:45:29 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/255340) ios-device on ...
3 years, 8 months ago (2017-04-26 03:45:30 UTC) #4
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-26 03:56:35 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/20001
3 years, 8 months ago (2017-04-26 03:56:54 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-26 04:11:39 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/198480) ios-simulator-xcode-clang on ...
3 years, 8 months ago (2017-04-26 04:11:40 UTC) #8
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-26 04:25:13 UTC) #9
Avi (use Gerrit)
Description was changed from ========== Update SupportsUserData uses with unique_ptr. BUG=690937 ========== to ========== Update ...
3 years, 8 months ago (2017-04-26 04:25:15 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/40001
3 years, 8 months ago (2017-04-26 04:25:37 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-26 04:39:05 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/83571)
3 years, 8 months ago (2017-04-26 04:39:07 UTC) #13
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-26 05:10:34 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/60001
3 years, 8 months ago (2017-04-26 05:10:50 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-26 05:24:30 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/198505)
3 years, 8 months ago (2017-04-26 05:24:32 UTC) #17
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-27 01:59:34 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/80001
3 years, 8 months ago (2017-04-27 02:00:31 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-27 02:15:58 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/199366) ios-simulator-xcode-clang on ...
3 years, 8 months ago (2017-04-27 02:15:59 UTC) #21
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-27 02:36:51 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/100001
3 years, 8 months ago (2017-04-27 02:37:25 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-27 02:50:48 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/88196)
3 years, 8 months ago (2017-04-27 02:50:49 UTC) #25
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-27 02:56:59 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/120001
3 years, 8 months ago (2017-04-27 02:57:36 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-27 03:13:02 UTC) #28
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/84473)
3 years, 8 months ago (2017-04-27 03:13:04 UTC) #29
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-27 03:20:12 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/140001
3 years, 8 months ago (2017-04-27 03:20:53 UTC) #31
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-27 03:27:34 UTC) #32
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/160001
3 years, 8 months ago (2017-04-27 03:27:45 UTC) #33
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-04-27 03:42:30 UTC) #34
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/199407)
3 years, 7 months ago (2017-04-27 03:42:31 UTC) #35
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-04-27 03:50:41 UTC) #36
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/180001
3 years, 7 months ago (2017-04-27 03:51:23 UTC) #37
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-04-27 03:55:21 UTC) #38
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/200001
3 years, 7 months ago (2017-04-27 03:55:52 UTC) #39
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-04-27 04:10:12 UTC) #40
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/199421) ios-simulator-xcode-clang on ...
3 years, 7 months ago (2017-04-27 04:10:13 UTC) #41
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-04-27 04:13:16 UTC) #42
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/220001
3 years, 7 months ago (2017-04-27 04:13:48 UTC) #43
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-04-27 04:31:11 UTC) #44
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/88247)
3 years, 7 months ago (2017-04-27 04:31:13 UTC) #45
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-04-27 04:34:42 UTC) #46
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/240001
3 years, 7 months ago (2017-04-27 04:35:17 UTC) #47
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-04-27 04:59:20 UTC) #48
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/260001
3 years, 7 months ago (2017-04-27 04:59:29 UTC) #49
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-04-27 05:30:06 UTC) #50
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/166044)
3 years, 7 months ago (2017-04-27 05:30:08 UTC) #51
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-04-28 01:33:33 UTC) #52
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/280001
3 years, 7 months ago (2017-04-28 01:35:26 UTC) #53
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-04-28 02:03:44 UTC) #54
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/281763)
3 years, 7 months ago (2017-04-28 02:03:46 UTC) #55
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-04-28 02:07:45 UTC) #56
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/300001
3 years, 7 months ago (2017-04-28 02:08:32 UTC) #57
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-04-28 02:59:25 UTC) #58
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/166862) linux_android_rel_ng on ...
3 years, 7 months ago (2017-04-28 02:59:26 UTC) #59
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-04-28 03:01:43 UTC) #60
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/320001
3 years, 7 months ago (2017-04-28 03:02:45 UTC) #61
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-04-28 03:35:46 UTC) #62
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/340001
3 years, 7 months ago (2017-04-28 03:36:02 UTC) #63
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-04-28 05:46:08 UTC) #64
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 7 months ago (2017-04-28 05:46:10 UTC) #65
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-04-29 18:59:40 UTC) #66
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/370001
3 years, 7 months ago (2017-04-29 18:59:49 UTC) #67
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-04-29 21:32:43 UTC) #68
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 7 months ago (2017-04-29 21:32:45 UTC) #69
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-01 02:39:04 UTC) #70
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/390001
3 years, 7 months ago (2017-05-01 02:39:18 UTC) #71
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-01 05:10:21 UTC) #72
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 7 months ago (2017-05-01 05:10:23 UTC) #73
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-02 02:35:15 UTC) #74
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842833003/410001
3 years, 7 months ago (2017-05-02 02:35:52 UTC) #75
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-02 05:02:03 UTC) #76
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 05:02:05 UTC) #77 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698