chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc - Issue 2842833003: Update SupportsUserData uses with unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc

Issue 2842833003: Update SupportsUserData uses with unique_ptr. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/metrics_web_contents_observer.cc ('k') | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc

index 3e9e2242d7cee13607b9b8fcdc6db0063c1cede6..a88983c1f5dc669e0948c630c1c80b60fde3bb5b 100644

--- a/chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc

@@ -75,7 +75,7 @@ void InjectDelayNavigationThrottleWebContentsObserver::CreateForWebContents(

if (!metrics) {

metrics = new InjectDelayNavigationThrottleWebContentsObserver(

web_contents, mock_time_task_runner);

- web_contents->SetUserData(UserDataKey(), metrics);

+ web_contents->SetUserData(UserDataKey(), base::WrapUnique(metrics));

}