chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.cc - Issue 2842833003: Update SupportsUserData uses with unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.cc

Issue 2842833003: Update SupportsUserData uses with unique_ptr. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/receiver_presentation_service_delegate_impl.cc ('k') | chrome/browser/metrics/renderer_uptime_web_contents_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.cc

diff --git a/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.cc b/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.cc

index 595729be732a6bf5b2e5e605eee110cc4cdd9757..5b35545f84f9497c7f91199543d3b35e7811ca2a 100644

--- a/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.cc

+++ b/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.h"

+#include "base/memory/ptr_util.h"

#include "chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker.h"

#include "content/public/browser/render_view_host.h"

@@ -33,7 +34,7 @@ DesktopSessionDurationObserver::CreateForWebContents(

if (!observer) {

observer = new DesktopSessionDurationObserver(

web_contents, DesktopSessionDurationTracker::Get());

- web_contents->SetUserData(UserDataKey(), observer);

+ web_contents->SetUserData(UserDataKey(), base::WrapUnique(observer));

}

return observer;

}