Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc

Issue 2842833003: Update SupportsUserData uses with unique_ptr. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/observers/delay_navigation_page_load_ metrics_observer.h" 5 #include "chrome/browser/page_load_metrics/observers/delay_navigation_page_load_ metrics_observer.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/run_loop.h" 10 #include "base/run_loop.h"
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 InjectDelayNavigationThrottleWebContentsObserver); 68 InjectDelayNavigationThrottleWebContentsObserver);
69 69
70 void InjectDelayNavigationThrottleWebContentsObserver::CreateForWebContents( 70 void InjectDelayNavigationThrottleWebContentsObserver::CreateForWebContents(
71 content::WebContents* web_contents, 71 content::WebContents* web_contents,
72 scoped_refptr<base::TestMockTimeTaskRunner> mock_time_task_runner) { 72 scoped_refptr<base::TestMockTimeTaskRunner> mock_time_task_runner) {
73 InjectDelayNavigationThrottleWebContentsObserver* metrics = 73 InjectDelayNavigationThrottleWebContentsObserver* metrics =
74 FromWebContents(web_contents); 74 FromWebContents(web_contents);
75 if (!metrics) { 75 if (!metrics) {
76 metrics = new InjectDelayNavigationThrottleWebContentsObserver( 76 metrics = new InjectDelayNavigationThrottleWebContentsObserver(
77 web_contents, mock_time_task_runner); 77 web_contents, mock_time_task_runner);
78 web_contents->SetUserData(UserDataKey(), metrics); 78 web_contents->SetUserData(UserDataKey(), base::WrapUnique(metrics));
79 } 79 }
80 } 80 }
81 81
82 class DelayNavigationPageLoadMetricsObserverTest 82 class DelayNavigationPageLoadMetricsObserverTest
83 : public page_load_metrics::PageLoadMetricsObserverTestHarness { 83 : public page_load_metrics::PageLoadMetricsObserverTestHarness {
84 public: 84 public:
85 void RegisterObservers(page_load_metrics::PageLoadTracker* tracker) override { 85 void RegisterObservers(page_load_metrics::PageLoadTracker* tracker) override {
86 tracker->AddObserver( 86 tracker->AddObserver(
87 base::MakeUnique<DelayNavigationPageLoadMetricsObserver>()); 87 base::MakeUnique<DelayNavigationPageLoadMetricsObserver>());
88 } 88 }
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 histogram_tester().ExpectTotalCount( 147 histogram_tester().ExpectTotalCount(
148 internal::kHistogramNavigationDelaySpecified, 1); 148 internal::kHistogramNavigationDelaySpecified, 1);
149 histogram_tester().ExpectBucketCount( 149 histogram_tester().ExpectBucketCount(
150 internal::kHistogramNavigationDelaySpecified, kDelayMillis, 1); 150 internal::kHistogramNavigationDelaySpecified, kDelayMillis, 1);
151 151
152 histogram_tester().ExpectTotalCount(internal::kHistogramNavigationDelayActual, 152 histogram_tester().ExpectTotalCount(internal::kHistogramNavigationDelayActual,
153 1); 153 1);
154 histogram_tester().ExpectTotalCount(internal::kHistogramNavigationDelayDelta, 154 histogram_tester().ExpectTotalCount(internal::kHistogramNavigationDelayDelta,
155 1); 155 1);
156 } 156 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698