chrome/browser/page_load_metrics/metrics_web_contents_observer.cc - Issue 2842833003: Update SupportsUserData uses with unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2842833003: Update SupportsUserData uses with unique_ptr. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

index 7a8b8068352ca5c8a85c0f139043e4cc4eeb812f..dbf296f4e4e984ab9245492fb4e0d87476b2a39a 100644

--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

@@ -84,7 +84,7 @@ MetricsWebContentsObserver* MetricsWebContentsObserver::CreateForWebContents(

if (!metrics) {

metrics = new MetricsWebContentsObserver(web_contents,

std::move(embedder_interface));

- web_contents->SetUserData(UserDataKey(), metrics);

+ web_contents->SetUserData(UserDataKey(), base::WrapUnique(metrics));

}

return metrics;

}