Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4271)

Unified Diff: chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc

Issue 2842833003: Update SupportsUserData uses with unique_ptr. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
diff --git a/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc b/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
index 8ef1560841b1f00779ed8b10beb25e8b913baebd..f7da400c932756f0b3f1683ebdc6e30cfee248a9 100644
--- a/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
+++ b/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
@@ -137,8 +137,9 @@ ChromeDataUseAscriber::GetOrCreateDataUseRecorderEntry(
DCHECK(frame_iter != main_render_frame_data_use_map_.end());
auto entry = frame_iter->second;
- request->SetUserData(DataUseRecorderEntryAsUserData::kUserDataKey,
- new DataUseRecorderEntryAsUserData(entry));
+ request->SetUserData(
+ DataUseRecorderEntryAsUserData::kUserDataKey,
+ base::MakeUnique<DataUseRecorderEntryAsUserData>(entry));
entry->AddPendingURLRequest(request);
return entry;
}
@@ -320,8 +321,9 @@ void ChromeDataUseAscriber::ReadyToCommitMainFrameNavigation(
for (auto* request : entry->pending_url_requests()) {
request->RemoveUserData(DataUseRecorderEntryAsUserData::kUserDataKey);
- request->SetUserData(DataUseRecorderEntryAsUserData::kUserDataKey,
- new DataUseRecorderEntryAsUserData(old_frame_entry));
+ request->SetUserData(
+ DataUseRecorderEntryAsUserData::kUserDataKey,
+ base::MakeUnique<DataUseRecorderEntryAsUserData>(old_frame_entry));
old_frame_entry->AddPendingURLRequest(request);
}
@@ -383,8 +385,9 @@ ChromeDataUseAscriber::CreateNewDataUseRecorder(net::URLRequest* request) {
data_use_recorders_.end());
if (request) {
entry->AddPendingURLRequest(request);
- request->SetUserData(DataUseRecorderEntryAsUserData::kUserDataKey,
- new DataUseRecorderEntryAsUserData(entry));
+ request->SetUserData(
+ DataUseRecorderEntryAsUserData::kUserDataKey,
+ base::MakeUnique<DataUseRecorderEntryAsUserData>(entry));
}
return entry;
}
« no previous file with comments | « chrome/browser/data_usage/tab_id_annotator.cc ('k') | chrome/browser/data_use_measurement/data_use_web_contents_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698