Renamed LoadCommittedDetails.is_in_page to is_same_document.

Renamed LoadCommittedDetails.is_in_page to is_same_document.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2841833002
Cr-Commit-Position: refs/heads/master@{#467720}
Committed: https://chromium.googlesource.com/chromium/src/+/ee08663ae2f6240b382249c849f5c42012143632

[Eugene But (OOO till 7-30), 2017-04-25 11:47:18]

Description was changed from

==========
Renamed LoadCommittedDetails.is_in_page to is_same_document.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189
==========

to

==========
Renamed LoadCommittedDetails.is_in_page to is_same_document.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Eugene But (OOO till 7-30), 2017-04-25 11:48:37]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 11:48:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 11:57:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 11:57:12]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[Eugene But (OOO till 7-30), 2017-04-25 12:05:17]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 12:05:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 12:13:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 12:13:08]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Eugene But (OOO till 7-30), 2017-04-25 13:10:08]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 13:10:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 13:25:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 13:25:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eugene But (OOO till 7-30), 2017-04-25 14:24:32]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 14:24:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 14:37:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 14:37:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eugene But (OOO till 7-30), 2017-04-25 16:05:09]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 16:05:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 17:29:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 17:29:46]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-04-25 20:51:46]

eugenebut@chromium.org changed reviewers:
+ clamy@chromium.org

[Eugene But (OOO till 7-30), 2017-04-25 20:51:47]

PTAL

[clamy, 2017-04-27 11:41:40]

Thanks for cleanup! content/ lgtm.

[Eugene But (OOO till 7-30), 2017-04-27 13:18:44]

eugenebut@chromium.org changed reviewers:
+ jam@chromium.org

[Eugene But (OOO till 7-30), 2017-04-27 13:18:45]

Thanks!

jam, PTAL at services and chrome/browser

[jam, 2017-04-27 15:33:34]

lgtm

[Eugene But (OOO till 7-30), 2017-04-27 16:02:14]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-04-27 16:03:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 17:43:15]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493308934748170,
"parent_rev": "594ca9154ab4c2597ea11b8d6bc6d873274a79ce", "commit_rev":
"ee08663ae2f6240b382249c849f5c42012143632"}

[commit-bot: I haz the power, 2017-04-27 17:43:33]

Description was changed from

==========
Renamed LoadCommittedDetails.is_in_page to is_same_document.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Renamed LoadCommittedDetails.is_in_page to is_same_document.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2841833002
Cr-Commit-Position: refs/heads/master@{#467720}
Committed:
https://chromium.googlesource.com/chromium/src/+/ee08663ae2f6240b382249c849f5...
==========

[commit-bot: I haz the power, 2017-04-27 17:43:38]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/ee08663ae2f6240b382249c849f5...