chrome/browser/ui/chrome_bubble_manager.cc - Issue 2841833002: Renamed LoadCommittedDetails.is_in_page to is_same_document.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/chrome_bubble_manager.cc

Issue 2841833002: Renamed LoadCommittedDetails.is_in_page to is_same_document. (Closed)

Patch Set: I said "once and for all" Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/chrome_bubble_manager.cc

diff --git a/chrome/browser/ui/chrome_bubble_manager.cc b/chrome/browser/ui/chrome_bubble_manager.cc

index 1d9a9fda2122c5ad8875809566bf7275f7c70411..da7d632bdf74d2d26f657866645c11f474c168b6 100644

--- a/chrome/browser/ui/chrome_bubble_manager.cc

+++ b/chrome/browser/ui/chrome_bubble_manager.cc

@@ -160,7 +160,7 @@ void ChromeBubbleManager::DidToggleFullscreenModeForTab(

void ChromeBubbleManager::NavigationEntryCommitted(

const content::LoadCommittedDetails& load_details) {

- if (!load_details.is_in_page)

+ if (!load_details.is_same_document)

CloseAllBubbles(BUBBLE_CLOSE_NAVIGATED);

}