Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1542)

Unified Diff: content/public/browser/navigation_details.h

Issue 2841833002: Renamed LoadCommittedDetails.is_in_page to is_same_document. (Closed)
Patch Set: I said "once and for all" Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/navigation_details.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/navigation_details.h
diff --git a/content/public/browser/navigation_details.h b/content/public/browser/navigation_details.h
index 6cbcbdc886deb0af3e045f2b12cf3f043b73c45f..1d224c049cc97e498a6dae4f483c6b27fa7680fc 100644
--- a/content/public/browser/navigation_details.h
+++ b/content/public/browser/navigation_details.h
@@ -43,9 +43,12 @@ struct CONTENT_EXPORT LoadCommittedDetails {
// A non-user initiated redirect causes such replacement.
bool did_replace_entry;
- // True if the navigation was in-page. This means that the active entry's
- // URL and the |previous_url| are the same except for reference fragments.
- bool is_in_page;
+ // Whether the navigation happened without changing document. Examples of
+ // same document navigations are:
+ // * reference fragment navigations
+ // * pushState/replaceState
+ // * same page history navigation
+ bool is_same_document;
// True when the main frame was navigated. False means the navigation was a
// sub-frame.
@@ -55,7 +58,7 @@ struct CONTENT_EXPORT LoadCommittedDetails {
// scrolling to a fragment inside the current page). We often need this logic
// for showing or hiding something.
bool is_navigation_to_different_page() const {
- return is_main_frame && !is_in_page;
+ return is_main_frame && !is_same_document;
}
// The HTTP status code for this entry..
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/navigation_details.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698