content/browser/web_contents/web_contents_impl.cc - Issue 2841833002: Renamed LoadCommittedDetails.is_in_page to is_same_document.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2841833002: Renamed LoadCommittedDetails.is_in_page to is_same_document. (Closed)

Patch Set: I said "once and for all" Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 661b4db001cf8a8554d4b13d30ff3275dc282e73..e17f555df95651a9f82db477c4c9ad9e175d253c 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -3544,7 +3544,7 @@ void WebContentsImpl::DidNavigateAnyFramePostCommit(

has_accessed_initial_document_ = false;

// If we navigate off the page, close all JavaScript dialogs.

- if (!details.is_in_page)

+ if (!details.is_same_document)

CancelActiveAndPendingDialogs();

// If this is a user-initiated navigation, start allowing JavaScript dialogs