services/navigation/view_impl.cc - Issue 2841833002: Renamed LoadCommittedDetails.is_in_page to is_same_document.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/navigation/view_impl.cc

Issue 2841833002: Renamed LoadCommittedDetails.is_in_page to is_same_document. (Closed)

Patch Set: I said "once and for all" Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/navigation/view_impl.cc

diff --git a/services/navigation/view_impl.cc b/services/navigation/view_impl.cc

index 655ccaa9c3ab1a2ca585887427d3f493c78dcd35..ceb788d01bbf406c331aeb14ce98bc998c9420ee 100644

--- a/services/navigation/view_impl.cc

+++ b/services/navigation/view_impl.cc

@@ -240,7 +240,7 @@ void ViewImpl::Observe(int type,

details_ptr->type = static_cast<mojom::NavigationType>(lcd->type);

details_ptr->previous_entry_index = lcd->previous_entry_index;

details_ptr->previous_url = lcd->previous_url;

- details_ptr->is_in_page = lcd->is_in_page;

+ details_ptr->is_in_page = lcd->is_same_document;

details_ptr->is_main_frame = lcd->is_main_frame;

details_ptr->http_status_code = lcd->http_status_code;

client_->NavigationCommitted(

« no previous file with comments | « content/public/browser/navigation_details.cc ('k') | no next file » | no next file with comments »