Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Unified Diff: chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc

Issue 2839753005: Remove base::Value::GetAsBinary (Closed)
Patch Set: ASSERT_TRUE Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
diff --git a/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc b/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
index 0a16e496606469b6584851e84c71553d0dadaf12..ea3cebef72dd5edb1fc5a97ab12f238ffd203bb2 100644
--- a/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
+++ b/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
@@ -72,13 +72,8 @@ void StoreString(std::string* result,
void StoreDigest(std::vector<uint8_t>* digest,
const base::Closure& callback,
const base::Value* value) {
- const base::Value* binary = nullptr;
- const bool is_binary = value->GetAsBinary(&binary);
- EXPECT_TRUE(is_binary) << "Unexpected value in StoreDigest";
- if (is_binary) {
- digest->assign(binary->GetBlob().begin(), binary->GetBlob().end());
- }
-
+ ASSERT_TRUE(value->is_blob()) << "Unexpected value in StoreDigest";
+ digest->assign(value->GetBlob().begin(), value->GetBlob().end());
callback.Run();
}

Powered by Google App Engine
This is Rietveld 408576698