Remove base::Value::GetAsBinary

mojo/common/values_struct_traits.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_COMMON_VALUES_STRUCT_TRAITS_H_
 #define MOJO_COMMON_VALUES_STRUCT_TRAITS_H_
 
 #include "base/values.h"
 #include "mojo/common/values.mojom.h"
 #include "mojo/public/cpp/bindings/array_traits.h"
@@ skipping 155 matching lines @@
   }
 
   static base::StringPiece string_value(const base::Value& value) {
     base::StringPiece string_piece;
     if (!value.GetAsString(&string_piece))
       NOTREACHED();
     return string_piece;
   }
 
   static mojo::ConstCArray<uint8_t> binary_value(const base::Value& value) {
-    const base::Value* binary_value = nullptr;
-    if (!value.GetAsBinary(&binary_value))
+    if (!value.is_blob())

[jdoerrie, 2017/04/25 12:49:16]

Technically this if-clause is not required either given that value.GetBlob()
CHECKs that value.is_blob(). 

However, given that this clause should not generate any code in release mode and
results in earlier failures in unit tests I decided to keep it. Thoughts?

[Robert Sesek, 2017/04/25 14:06:42]

I'd keep it given the pattern in the rest of the file.

[jdoerrie, 2017/04/25 14:14:33]

Acknowledged.

       NOTREACHED();
     return mojo::ConstCArray<uint8_t>(
-        binary_value->GetBlob().size(),
-        reinterpret_cast<const uint8_t*>(binary_value->GetBlob().data()));
+        value.GetBlob().size(),
+        reinterpret_cast<const uint8_t*>(value.GetBlob().data()));
   }
 
   static const base::ListValue& list_value(const base::Value& value) {
     const base::ListValue* list_value = nullptr;
     if (!value.GetAsList(&list_value))
       NOTREACHED();
     return *list_value;
   }
   static const base::DictionaryValue& dictionary_value(
       const base::Value& value) {
@@ skipping 56 matching lines @@
                        base::Value>::dictionary_value(*value);
   }
 
   static bool Read(common::mojom::ValueDataView data,
                    std::unique_ptr<base::Value>* value);
 };
 
 }  // namespace mojo
 
 #endif  // MOJO_COMMON_VALUES_STRUCT_TRAITS_H_