Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4227)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/values_unittest.cc

Issue 2839753005: Remove base::Value::GetAsBinary (Closed)
Patch Set: ASSERT_TRUE Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/values.cc ('k') | chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/values_unittest.cc
diff --git a/base/values_unittest.cc b/base/values_unittest.cc
index 1b5ff3cb3cca577d097a38ded7a5098810e5b4f8..a781dc47984040f8b8c5843e8045e420e4ef8124 100644
--- a/base/values_unittest.cc
+++ b/base/values_unittest.cc
@@ -462,12 +462,6 @@ TEST(ValuesTest, BinaryValue) {
ASSERT_EQ(42U, binary->GetBlob().size());
ASSERT_EQ(0, memcmp(stack_buffer, binary->GetBlob().data(),
binary->GetBlob().size()));
-
- // Test overloaded GetAsBinary.
- Value* narrow_value = binary.get();
- const Value* narrow_binary = NULL;
- ASSERT_TRUE(narrow_value->GetAsBinary(&narrow_binary));
- EXPECT_EQ(binary.get(), narrow_binary);
}
TEST(ValuesTest, StringValue) {
« no previous file with comments | « base/values.cc ('k') | chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698