[stubs] Drop CallApiCallbackStub::call_data_undefined optimization.

[stubs] Drop CallApiCallbackStub::call_data_undefined optimization.

The CallApiCallbackStub can avoid loading undefined in case the
call_data is already undefined, which doubles the number of versions of
the stub and adds unnecessary complexity (at the benefit of saving one
stupid load). The idea is to turn the CallApiCallbackStub into a single
builtin instead, which does the right thing, so this is the first step
towards that goal.

R=yangguo@chromium.org
BUG=v8:6304
Review-Url: https://codereview.chromium.org/2838143003
Cr-Commit-Position: refs/heads/master@{#44869}
Committed: https://chromium.googlesource.com/v8/v8/+/46d0e4818a361b3fb535e1c78973b4d1ace000dc

[Benedikt Meurer, 2017-04-25 17:09:47]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 17:09:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 17:13:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 17:13:02]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/24852)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/21450)

[Benedikt Meurer, 2017-04-25 17:14:55]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 17:15:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-04-25 17:16:05]

Hey Yang,

Here's a first step towards simplifying the CallApiCallbackStub. Please take a
look.

Thanks,
Benedikt

[commit-bot: I haz the power, 2017-04-25 17:42:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 17:42:56]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-04-25 19:46:22]

lgtm

[Benedikt Meurer, 2017-04-25 19:46:58]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-04-25 19:47:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 19:48:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493149618245450,
"parent_rev": "f385b747eb8ce875344822f0a287f9a0bb0acc6f", "commit_rev":
"46d0e4818a361b3fb535e1c78973b4d1ace000dc"}

[commit-bot: I haz the power, 2017-04-25 19:48:30]

Description was changed from

==========
[stubs] Drop CallApiCallbackStub::call_data_undefined optimization.

The CallApiCallbackStub can avoid loading undefined in case the
call_data is already undefined, which doubles the number of versions of
the stub and adds unnecessary complexity (at the benefit of saving one
stupid load). The idea is to turn the CallApiCallbackStub into a single
builtin instead, which does the right thing, so this is the first step
towards that goal.

R=yangguo@chromium.org
BUG=v8:6304
==========

to

==========
[stubs] Drop CallApiCallbackStub::call_data_undefined optimization.

The CallApiCallbackStub can avoid loading undefined in case the
call_data is already undefined, which doubles the number of versions of
the stub and adds unnecessary complexity (at the benefit of saving one
stupid load). The idea is to turn the CallApiCallbackStub into a single
builtin instead, which does the right thing, so this is the first step
towards that goal.

R=yangguo@chromium.org
BUG=v8:6304

Review-Url: https://codereview.chromium.org/2838143003
Cr-Commit-Position: refs/heads/master@{#44869}
Committed:
https://chromium.googlesource.com/v8/v8/+/46d0e4818a361b3fb535e1c78973b4d1ace...
==========

[commit-bot: I haz the power, 2017-04-25 19:48:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/46d0e4818a361b3fb535e1c78973b4d1ace...