Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: src/code-stubs.h

Issue 2838143003: [stubs] Drop CallApiCallbackStub::call_data_undefined optimization. (Closed)
Patch Set: Fix handler-compiler for remaining archs. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/code-stubs-arm64.cc ('k') | src/compiler/js-call-reducer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index bfacf6c62cc5682df71cf992129185ff62a81d80..7a1b905fd6846e5685479520be90386161186d25 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -827,39 +827,29 @@ class CallApiCallbackStub : public PlatformCodeStub {
static const int kArgMax = (1 << kArgBits) - 1;
// CallApiCallbackStub for regular setters and getters.
- CallApiCallbackStub(Isolate* isolate, bool is_store, bool call_data_undefined,
- bool is_lazy)
- : CallApiCallbackStub(isolate, is_store ? 1 : 0, is_store,
- call_data_undefined, is_lazy) {}
+ CallApiCallbackStub(Isolate* isolate, bool is_store, bool is_lazy)
+ : CallApiCallbackStub(isolate, is_store ? 1 : 0, is_store, is_lazy) {}
// CallApiCallbackStub for callback functions.
- CallApiCallbackStub(Isolate* isolate, int argc, bool call_data_undefined,
- bool is_lazy)
- : CallApiCallbackStub(isolate, argc, false, call_data_undefined,
- is_lazy) {}
+ CallApiCallbackStub(Isolate* isolate, int argc, bool is_lazy)
+ : CallApiCallbackStub(isolate, argc, false, is_lazy) {}
private:
- CallApiCallbackStub(Isolate* isolate, int argc, bool is_store,
- bool call_data_undefined, bool is_lazy)
+ CallApiCallbackStub(Isolate* isolate, int argc, bool is_store, bool is_lazy)
: PlatformCodeStub(isolate) {
CHECK(0 <= argc && argc <= kArgMax);
minor_key_ = IsStoreBits::encode(is_store) |
- CallDataUndefinedBits::encode(call_data_undefined) |
ArgumentBits::encode(argc) |
IsLazyAccessorBits::encode(is_lazy);
}
bool is_store() const { return IsStoreBits::decode(minor_key_); }
bool is_lazy() const { return IsLazyAccessorBits::decode(minor_key_); }
- bool call_data_undefined() const {
- return CallDataUndefinedBits::decode(minor_key_);
- }
int argc() const { return ArgumentBits::decode(minor_key_); }
class IsStoreBits: public BitField<bool, 0, 1> {};
- class CallDataUndefinedBits: public BitField<bool, 1, 1> {};
+ class IsLazyAccessorBits : public BitField<bool, 1, 1> {};
class ArgumentBits : public BitField<int, 2, kArgBits> {};
- class IsLazyAccessorBits : public BitField<bool, 3 + kArgBits, 1> {};
DEFINE_CALL_INTERFACE_DESCRIPTOR(ApiCallback);
DEFINE_PLATFORM_CODE_STUB(CallApiCallback, PlatformCodeStub);
« no previous file with comments | « src/arm64/code-stubs-arm64.cc ('k') | src/compiler/js-call-reducer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698