src/arm/code-stubs-arm.cc - Issue 2838143003: [stubs] Drop CallApiCallbackStub::call_data_undefined optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/code-stubs-arm.cc

Issue 2838143003: [stubs] Drop CallApiCallbackStub::call_data_undefined optimization. (Closed)

Patch Set: Fix handler-compiler for remaining archs. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/code-stubs-arm.cc

diff --git a/src/arm/code-stubs-arm.cc b/src/arm/code-stubs-arm.cc

index 2459f987672488293393aa825d6ab719af4bf23a..fc59f4007e1589f75e219534a55db84a1eb6f8af 100644

--- a/src/arm/code-stubs-arm.cc

+++ b/src/arm/code-stubs-arm.cc

@@ -2799,9 +2799,7 @@ void CallApiCallbackStub::Generate(MacroAssembler* masm) {

__ push(call_data);

- if (!call_data_undefined()) {

- __ LoadRoot(scratch, Heap::kUndefinedValueRootIndex);

- }

+ __ LoadRoot(scratch, Heap::kUndefinedValueRootIndex);

// return value

__ push(scratch);

// return value default

« no previous file with comments | « no previous file | src/arm64/code-stubs-arm64.cc » ('j') | no next file with comments »