src/ia32/code-stubs-ia32.cc - Issue 2838143003: [stubs] Drop CallApiCallbackStub::call_data_undefined optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/code-stubs-ia32.cc

Issue 2838143003: [stubs] Drop CallApiCallbackStub::call_data_undefined optimization. (Closed)

Patch Set: Fix handler-compiler for remaining archs. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/code-stubs-ia32.cc

diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc

index 0afefc391cd39aa90621491f8de943ce57caa0b7..6550d6e016cb587cb9bc22a6ac3c61333ac1ad6b 100644

--- a/src/ia32/code-stubs-ia32.cc

+++ b/src/ia32/code-stubs-ia32.cc

@@ -2780,23 +2780,16 @@ void CallApiCallbackStub::Generate(MacroAssembler* masm) {

// call data

__ push(call_data);

- Register scratch = call_data;

- if (!call_data_undefined()) {

- // return value

- __ push(Immediate(masm->isolate()->factory()->undefined_value()));

- // return value default

- __ push(Immediate(masm->isolate()->factory()->undefined_value()));

- } else {

- // return value

- __ push(scratch);

- // return value default

- __ push(scratch);

- }

+ // return value

+ __ push(Immediate(masm->isolate()->factory()->undefined_value()));

+ // return value default

+ __ push(Immediate(masm->isolate()->factory()->undefined_value()));

// isolate

__ push(Immediate(reinterpret_cast<int>(masm->isolate())));

// holder

__ push(holder);

+ Register scratch = call_data;

__ mov(scratch, esp);

// push return address

« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/ic/arm/handler-compiler-arm.cc » ('j') | no next file with comments »