Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2839953002: [turbofan] Optimize API function calls based on inferred receiver maps. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize API function calls based on inferred receiver maps. Previously API function calls would only be optimized in TurboFan when the receiver was a (compile-time) known constant, which was probably only true for certain cases where functions where called on the global proxy (the window object). BUG=v8:5267, v8:6304 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2839953002 Cr-Commit-Position: refs/heads/master@{#44877} Committed: https://chromium.googlesource.com/v8/v8/+/5361f7ff32c3d30babee479c56b3865d0500e476

Patch Set 1 #

Patch Set 2 : Update comment. #

Patch Set 3 : Only handle simple API calls. #

Patch Set 4 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -113 lines) Patch
M src/compiler/js-call-reducer.h View 2 chunks +2 lines, -8 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 1 2 3 5 chunks +82 lines, -105 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 22 (18 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-25 12:59:24 UTC) #1
Jarin
lgtm
3 years, 8 months ago (2017-04-26 05:10:14 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839953002/60001
3 years, 8 months ago (2017-04-26 05:14:05 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 05:15:27 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/5361f7ff32c3d30babee479c56b3865d050...

Powered by Google App Engine
This is Rietveld 408576698