Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2838113002: Simplify QUIC tests by adding a MakeInitialSettingsPacket method (Closed)

Created:
3 years, 8 months ago by Ryan Hamilton
Modified:
3 years, 8 months ago
Reviewers:
Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify QUIC tests by adding a MakeInitialSettingsPacket method to QuicTestPacketMaker. Review-Url: https://codereview.chromium.org/2838113002 Cr-Commit-Position: refs/heads/master@{#467090} Committed: https://chromium.googlesource.com/chromium/src/+/5cb52246012a13494269d5316af065201a8725b4

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -578 lines) Patch
M net/http/http_stream_factory_impl_unittest.cc View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc View 1 2 14 chunks +15 lines, -43 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session_test.cc View 1 2 17 chunks +17 lines, -51 lines 0 comments Download
M net/quic/chromium/quic_http_stream_test.cc View 1 2 21 chunks +22 lines, -65 lines 0 comments Download
M net/quic/chromium/quic_network_transaction_unittest.cc View 1 2 48 chunks +94 lines, -152 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 1 2 69 chunks +96 lines, -239 lines 0 comments Download
M net/quic/chromium/quic_test_packet_maker.h View 1 2 1 chunk +4 lines, -8 lines 0 comments Download
M net/quic/chromium/quic_test_packet_maker.cc View 1 2 1 chunk +9 lines, -14 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
Ryan Hamilton
3 years, 8 months ago (2017-04-25 06:56:39 UTC) #3
Jana
lgtm
3 years, 8 months ago (2017-04-25 18:57:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838113002/20001
3 years, 8 months ago (2017-04-25 19:03:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/419963)
3 years, 8 months ago (2017-04-25 19:14:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838113002/40001
3 years, 8 months ago (2017-04-25 19:29:12 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 20:20:29 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5cb52246012a13494269d5316af0...

Powered by Google App Engine
This is Rietveld 408576698