Simplify QUIC tests by adding a MakeInitialSettingsPacket method

net/quic/chromium/quic_test_packet_maker.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/chromium/quic_test_packet_maker.h"
 
 #include <list>
 #include <utility>
 
 #include "base/memory/ptr_util.h"
@@ skipping 633 matching lines @@
 
 void QuicTestPacketMaker::InitializeHeader(QuicPacketNumber packet_number,
                                            bool should_include_version) {
   header_.public_header.connection_id = connection_id_;
   header_.public_header.reset_flag = false;
   header_.public_header.version_flag = should_include_version;
   header_.public_header.packet_number_length = PACKET_1BYTE_PACKET_NUMBER;
   header_.packet_number = packet_number;
 }
 
-std::unique_ptr<QuicReceivedPacket> QuicTestPacketMaker::MakeSettingsPacket(
-    QuicPacketNumber packet_number,
-    SpdySettingsIds id,
-    size_t value,
-    bool should_include_version,
-    QuicStreamOffset* offset) {
+std::unique_ptr<QuicReceivedPacket>
+QuicTestPacketMaker::MakeInitialSettingsPacket(QuicPacketNumber packet_number,
+                                               QuicStreamOffset* offset) {
   std::string unused_data;
-  return MakeSettingsPacketAndSaveData(
-      packet_number, id, value, should_include_version, offset, &unused_data);
+  return MakeInitialSettingsPacketAndSaveData(packet_number, offset,
+                                              &unused_data);
 }
 
 std::unique_ptr<QuicReceivedPacket>
-QuicTestPacketMaker::MakeSettingsPacketAndSaveData(
+QuicTestPacketMaker::MakeInitialSettingsPacketAndSaveData(
     QuicPacketNumber packet_number,
-    SpdySettingsIds id,
-    size_t value,
-    bool should_include_version,
     QuicStreamOffset* offset,
     std::string* stream_data) {
   SpdySettingsIR settings_frame;
-  settings_frame.AddSetting(id, value);
+  settings_frame.AddSetting(SETTINGS_MAX_HEADER_LIST_SIZE,
+                            kDefaultMaxUncompressedHeaderSize);
   SpdySerializedFrame spdy_frame(
       spdy_request_framer_.SerializeFrame(settings_frame));
-  InitializeHeader(packet_number, should_include_version);
+  InitializeHeader(packet_number, /*should_include_version*/ true);
   *stream_data = std::string(spdy_frame.data(), spdy_frame.size());
   if (offset != nullptr) {
     QuicStreamFrame quic_frame(
         kHeadersStreamId, false, *offset,
         QuicStringPiece(spdy_frame.data(), spdy_frame.size()));
     *offset += spdy_frame.size();
     return MakePacket(header_, QuicFrame(&quic_frame));
   }
   QuicStreamFrame quic_frame(
       kHeadersStreamId, false, 0,
       QuicStringPiece(spdy_frame.data(), spdy_frame.size()));
   return MakePacket(header_, QuicFrame(&quic_frame));
 }
 
 }  // namespace test
 }  // namespace net