Simplify QUIC tests by adding a MakeInitialSettingsPacket method

net/quic/chromium/quic_test_packet_maker.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Provides a simple interface for QUIC tests to create a variety of packets.
 
 #ifndef NET_QUIC_CHROMIUM_QUIC_TEST_PACKET_MAKER_H_
 #define NET_QUIC_CHROMIUM_QUIC_TEST_PACKET_MAKER_H_
 
 #include <stddef.h>
@@ skipping 198 matching lines @@
   // Convenience method for calling MakeResponseHeadersPacket with nullptr for
   // |spdy_headers_frame_length|.
   std::unique_ptr<QuicReceivedPacket>
   MakeResponseHeadersPacketWithOffsetTracking(QuicPacketNumber packet_number,
                                               QuicStreamId stream_id,
                                               bool should_include_version,
                                               bool fin,
                                               SpdyHeaderBlock headers,
                                               QuicStreamOffset* offset);
 
-  std::unique_ptr<QuicReceivedPacket> MakeSettingsPacket(
+  // Creates a packet containing the initial SETTINGS frame, and saves the
+  // headers stream offset into |offset|.
+  std::unique_ptr<QuicReceivedPacket> MakeInitialSettingsPacket(
       QuicPacketNumber packet_number,
-      SpdySettingsIds id,
-      size_t value,
-      bool should_include_version,
       QuicStreamOffset* offset);
 
   // Same as above, but also saves the serialized QUIC stream data in
   // |stream_data|.
-  std::unique_ptr<QuicReceivedPacket> MakeSettingsPacketAndSaveData(
+  std::unique_ptr<QuicReceivedPacket> MakeInitialSettingsPacketAndSaveData(
       QuicPacketNumber packet_number,
-      SpdySettingsIds id,
-      size_t value,
-      bool should_include_version,
       QuicStreamOffset* offset,
       std::string* stream_data);
 
   SpdyHeaderBlock GetRequestHeaders(const std::string& method,
                                     const std::string& scheme,
                                     const std::string& path);
   SpdyHeaderBlock GetResponseHeaders(const std::string& status);
 
   SpdyHeaderBlock GetResponseHeaders(const std::string& status,
                                      const std::string& alt_svc);
@@ skipping 18 matching lines @@
   QuicPacketHeader header_;
   Perspective perspective_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicTestPacketMaker);
 };
 
 }  // namespace test
 }  // namespace net
 
 #endif  // NET_QUIC_CHROMIUM_QUIC_TEST_PACKET_MAKER_H_