Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: net/quic/chromium/quic_test_packet_maker.cc

Issue 2838113002: Simplify QUIC tests by adding a MakeInitialSettingsPacket method (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/chromium/quic_test_packet_maker.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_test_packet_maker.cc
diff --git a/net/quic/chromium/quic_test_packet_maker.cc b/net/quic/chromium/quic_test_packet_maker.cc
index 1ef4ac83f123e42fa0e303f4164f04d3c2f12580..6a692ec7f6dbb70f32a0b02845e67d4126b3e02b 100644
--- a/net/quic/chromium/quic_test_packet_maker.cc
+++ b/net/quic/chromium/quic_test_packet_maker.cc
@@ -651,30 +651,25 @@ void QuicTestPacketMaker::InitializeHeader(QuicPacketNumber packet_number,
header_.packet_number = packet_number;
}
-std::unique_ptr<QuicReceivedPacket> QuicTestPacketMaker::MakeSettingsPacket(
- QuicPacketNumber packet_number,
- SpdySettingsIds id,
- size_t value,
- bool should_include_version,
- QuicStreamOffset* offset) {
+std::unique_ptr<QuicReceivedPacket>
+QuicTestPacketMaker::MakeInitialSettingsPacket(QuicPacketNumber packet_number,
+ QuicStreamOffset* offset) {
std::string unused_data;
- return MakeSettingsPacketAndSaveData(
- packet_number, id, value, should_include_version, offset, &unused_data);
+ return MakeInitialSettingsPacketAndSaveData(packet_number, offset,
+ &unused_data);
}
std::unique_ptr<QuicReceivedPacket>
-QuicTestPacketMaker::MakeSettingsPacketAndSaveData(
+QuicTestPacketMaker::MakeInitialSettingsPacketAndSaveData(
QuicPacketNumber packet_number,
- SpdySettingsIds id,
- size_t value,
- bool should_include_version,
QuicStreamOffset* offset,
std::string* stream_data) {
SpdySettingsIR settings_frame;
- settings_frame.AddSetting(id, value);
+ settings_frame.AddSetting(SETTINGS_MAX_HEADER_LIST_SIZE,
+ kDefaultMaxUncompressedHeaderSize);
SpdySerializedFrame spdy_frame(
spdy_request_framer_.SerializeFrame(settings_frame));
- InitializeHeader(packet_number, should_include_version);
+ InitializeHeader(packet_number, /*should_include_version*/ true);
*stream_data = std::string(spdy_frame.data(), spdy_frame.size());
if (offset != nullptr) {
QuicStreamFrame quic_frame(
« no previous file with comments | « net/quic/chromium/quic_test_packet_maker.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698