Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Unified Diff: net/http/http_stream_factory_impl_unittest.cc

Issue 2838113002: Simplify QUIC tests by adding a MakeInitialSettingsPacket method (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_unittest.cc
diff --git a/net/http/http_stream_factory_impl_unittest.cc b/net/http/http_stream_factory_impl_unittest.cc
index 3d77064ed358d7a88cbf59ec152d609253b6dc5b..9565d7f591aaa9acbbfc68d1e566dbc83e7d7c7a 100644
--- a/net/http/http_stream_factory_impl_unittest.cc
+++ b/net/http/http_stream_factory_impl_unittest.cc
@@ -2267,9 +2267,8 @@ TEST_P(HttpStreamFactoryBidirectionalQuicTest,
ConvertRequestPriorityToQuicPriority(DEFAULT_PRIORITY);
size_t spdy_headers_frame_length;
QuicStreamOffset header_stream_offset = 0;
- mock_quic_data.AddWrite(client_packet_maker().MakeSettingsPacket(
- 1, SETTINGS_MAX_HEADER_LIST_SIZE, kDefaultMaxUncompressedHeaderSize, true,
- &header_stream_offset));
+ mock_quic_data.AddWrite(client_packet_maker().MakeInitialSettingsPacket(
+ 1, &header_stream_offset));
mock_quic_data.AddWrite(client_packet_maker().MakeRequestHeadersPacket(
2, test::kClientDataStreamId1, /*should_include_version=*/true,
/*fin=*/true, priority,
@@ -2396,9 +2395,8 @@ TEST_P(HttpStreamFactoryBidirectionalQuicTest,
ConvertRequestPriorityToQuicPriority(DEFAULT_PRIORITY);
size_t spdy_headers_frame_length;
QuicStreamOffset header_stream_offset = 0;
- mock_quic_data.AddWrite(client_packet_maker().MakeSettingsPacket(
- 1, SETTINGS_MAX_HEADER_LIST_SIZE, kDefaultMaxUncompressedHeaderSize, true,
- &header_stream_offset));
+ mock_quic_data.AddWrite(client_packet_maker().MakeInitialSettingsPacket(
+ 1, &header_stream_offset));
mock_quic_data.AddWrite(client_packet_maker().MakeRequestHeadersPacket(
2, test::kClientDataStreamId1, /*should_include_version=*/true,
/*fin=*/true, priority,
« no previous file with comments | « no previous file | net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698