Merged all PointerToId functions into TraceHelper::PointerToString.

Merged all PointerToId functions into TraceHelper::PointerToString.

There are many places in scheduler/renderer that need to make a string
out of a pointer for tracing purposes. This creates a shared function
for them.

This was noticed while experimenting with jumbo builds which can not
handle reused symbol names in the global or global anonymous scope.

Review-Url: https://codereview.chromium.org/2837323002
Cr-Commit-Position: refs/heads/master@{#470948}
Committed: https://chromium.googlesource.com/chromium/src/+/ee9188fc71ffc068df4a6a990f7278af5706641b

[Daniel Bratell, 2017-04-25 17:18:52]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 17:19:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 20:08:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 20:08:40]

Dry run: This issue passed the CQ dry run.

[Daniel Bratell, 2017-04-27 09:17:00]

bratell@opera.com changed reviewers:
+ alexclarke@chromium.org

[Daniel Bratell, 2017-04-27 09:17:01]

alexclarke, could you please take a look at this patch?

As you may have noticed (or not), I am trying to introduce jumbo builds where
compilation units are merged and if compilation units have the same symbol names
they need to be excluded which is unfortunate.

So my purpose of this patch is to only have a single PointerToId() in the global
(or global anonymous) scope in platform. 

Since the side effect is less code I hope it is an improvement even if jumbo
never happens.

[alex clarke (OOO till 29th), 2017-05-10 07:45:35]

Sorry I completely missed this patch.  It looks fine but will need rebasing.

[Daniel Bratell, 2017-05-10 13:45:09]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 13:45:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Bratell, 2017-05-10 15:29:10]

Rebased it and applied to new PointerToId instances. Can you take a new look?

[commit-bot: I haz the power, 2017-05-10 15:31:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 15:31:32]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[alex clarke (OOO till 29th), 2017-05-10 16:45:12]

lgtm

[Daniel Bratell, 2017-05-11 07:41:31]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2017-05-11 07:42:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 07:56:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 07:56:44]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Daniel Bratell, 2017-05-11 08:50:57]

bratell@opera.com changed reviewers:
+ jochen@chromium.org

[Daniel Bratell, 2017-05-11 08:50:58]

jochen, could you review the added files to platform/BUILD.gn please?

[jochen (gone - plz use gerrit), 2017-05-11 08:53:11]

BUILD.gn lgtm

please consider addressing the nits

https://codereview.chromium.org/2837323002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scheduler/base/trace_helper.h (right):

https://codereview.chromium.org/2837323002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/trace_helper.h:13: class
TraceHelper {
nit. should be a namespace (all static classes in general should be namespaces)

https://codereview.chromium.org/2837323002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/trace_helper.h:16: bool
add_hex_prefix = true);
ideally that would be an enum class, no a bool

[Daniel Bratell, 2017-05-11 09:14:32]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 09:15:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 09:25:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 09:25:32]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Daniel Bratell, 2017-05-11 09:27:27]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 09:28:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 09:39:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 09:39:52]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Daniel Bratell, 2017-05-11 09:45:11]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 09:46:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 09:58:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 09:58:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Daniel Bratell, 2017-05-11 10:13:45]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 10:14:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Bratell, 2017-05-11 11:51:20]

Thanks for the review (and sorry for all the spam; thought it would be much
faster to let cq test compile the review fixes than doing it locally and this
time I was probably wrong).

https://codereview.chromium.org/2837323002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scheduler/base/trace_helper.h (right):

https://codereview.chromium.org/2837323002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/trace_helper.h:13: class
TraceHelper {
On 2017/05/11 08:53:11, jochen wrote:
> nit. should be a namespace (all static classes in general should be
namespaces)

Done.

https://codereview.chromium.org/2837323002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/trace_helper.h:16: bool
add_hex_prefix = true);
On 2017/05/11 08:53:11, jochen wrote:
> ideally that would be an enum class, no a bool

I have been uncertain about this flag since it's only needed for a single call
site. Making it an enum would clearly pass the threshold of "not worth it" so I
dropped the flag completely instead and let that call site handle the conversion
itself.

[commit-bot: I haz the power, 2017-05-11 14:09:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 14:09:20]

Dry run: This issue passed the CQ dry run.

[Daniel Bratell, 2017-05-11 14:23:40]

The CQ bit was checked by bratell@opera.com

[Daniel Bratell, 2017-05-11 14:23:41]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
alexclarke@chromium.org
Link to the patchset: https://codereview.chromium.org/2837323002/#ps100001
(title: "Converted TraceHelper the class to trace_helper the namespace.")

[commit-bot: I haz the power, 2017-05-11 14:24:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 14:31:21]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1494512620931340,
"parent_rev": "31a646c7268cb0957b681ede8332da9bdc513bd2", "commit_rev":
"ee9188fc71ffc068df4a6a990f7278af5706641b"}

[commit-bot: I haz the power, 2017-05-11 14:31:29]

Description was changed from

==========
Merged all PointerToId functions into TraceHelper::PointerToString.

There are many places in scheduler/renderer that need to make a string
out of a pointer for tracing purposes. This creates a shared function
for them.

This was noticed while experimenting with jumbo builds which can not
handle reused symbol names in the global or global anonymous scope.
==========

to

==========
Merged all PointerToId functions into TraceHelper::PointerToString.

There are many places in scheduler/renderer that need to make a string
out of a pointer for tracing purposes. This creates a shared function
for them.

This was noticed while experimenting with jumbo builds which can not
handle reused symbol names in the global or global anonymous scope.

Review-Url: https://codereview.chromium.org/2837323002
Cr-Commit-Position: refs/heads/master@{#470948}
Committed:
https://chromium.googlesource.com/chromium/src/+/ee9188fc71ffc068df4a6a990f72...
==========

[commit-bot: I haz the power, 2017-05-11 14:31:30]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/ee9188fc71ffc068df4a6a990f72...