Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/cpu_time_budget_pool.cc

Issue 2837323002: Merged all PointerToId functions into TraceHelper::PointerToString. (Closed)
Patch Set: Converted TraceHelper the class to trace_helper the namespace. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/cpu_time_budget_pool.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/cpu_time_budget_pool.cc b/third_party/WebKit/Source/platform/scheduler/renderer/cpu_time_budget_pool.cc
index 96eb942dfa158185a50e4e51543bd1095ca438bb..dc86aa76c1b1764d549f579c714571df0f811de7 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/cpu_time_budget_pool.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/cpu_time_budget_pool.cc
@@ -6,26 +6,15 @@
#include <cstdint>
-#include "base/format_macros.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
#include "base/optional.h"
-#include "base/strings/stringprintf.h"
+#include "platform/scheduler/base/trace_helper.h"
#include "platform/scheduler/renderer/task_queue_throttler.h"
namespace blink {
namespace scheduler {
-namespace {
-
-std::string PointerToId(void* pointer) {
- return base::StringPrintf(
- "0x%" PRIx64,
- static_cast<uint64_t>(reinterpret_cast<uintptr_t>(pointer)));
-}
-
-} // namespace
-
CPUTimeBudgetPool::CPUTimeBudgetPool(
const char* name,
BudgetPoolController* budget_pool_controller,
@@ -153,7 +142,7 @@ void CPUTimeBudgetPool::AsValueInto(base::trace_event::TracedValue* state,
state->BeginArray("task_queues");
for (TaskQueue* queue : associated_task_queues_) {
- state->AppendString(PointerToId(queue));
+ state->AppendString(trace_helper::PointerToString(queue));
}
state->EndArray();

Powered by Google App Engine
This is Rietveld 408576698