Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Issue 2837323002: Merged all PointerToId functions into TraceHelper::PointerToString. (Closed)
Patch Set: Converted TraceHelper the class to trace_helper the namespace. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
index c7e246c3372e92b106d974da3bdd55a8edb0405a..0ca796ec645f602592374ca9c3e6feee65b6e657 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
@@ -9,7 +9,6 @@
#include "base/logging.h"
#include "base/memory/ptr_util.h"
#include "base/metrics/histogram_macros.h"
-#include "base/strings/stringprintf.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/trace_event/trace_event.h"
#include "base/trace_event/trace_event_argument.h"
@@ -19,6 +18,7 @@
#include "platform/scheduler/base/task_queue_impl.h"
#include "platform/scheduler/base/task_queue_selector.h"
#include "platform/scheduler/base/time_converter.h"
+#include "platform/scheduler/base/trace_helper.h"
#include "platform/scheduler/base/virtual_time_domain.h"
#include "platform/scheduler/child/scheduler_tqm_delegate.h"
#include "platform/scheduler/renderer/auto_advancing_virtual_time_domain.h"
@@ -77,12 +77,6 @@ void ReportBackgroundRendererTaskLoad(base::TimeTicks time, double load) {
"RendererScheduler.BackgroundRendererLoad", load_percentage);
}
-std::string PointerToId(void* pointer) {
- return base::StringPrintf(
- "0x%" PRIx64,
- static_cast<uint64_t>(reinterpret_cast<uintptr_t>(pointer)));
-}
-
} // namespace
RendererSchedulerImpl::RendererSchedulerImpl(
@@ -1517,7 +1511,8 @@ RendererSchedulerImpl::AsValueLocked(base::TimeTicks optional_now) const {
state->BeginDictionary("web_view_schedulers");
for (WebViewSchedulerImpl* web_view_scheduler :
GetMainThreadOnly().web_view_schedulers) {
- state->BeginDictionaryWithCopiedName(PointerToId(web_view_scheduler));
+ state->BeginDictionaryWithCopiedName(
+ trace_helper::PointerToString(web_view_scheduler));
web_view_scheduler->AsValueInto(state.get());
state->EndDictionary();
}

Powered by Google App Engine
This is Rietveld 408576698