Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Issue 2837323002: Merged all PointerToId functions into TraceHelper::PointerToString. (Closed)
Patch Set: Converted TraceHelper the class to trace_helper the namespace. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/scheduler/renderer/renderer_scheduler_impl.h" 5 #include "platform/scheduler/renderer/renderer_scheduler_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/debug/stack_trace.h" 8 #include "base/debug/stack_trace.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
11 #include "base/metrics/histogram_macros.h" 11 #include "base/metrics/histogram_macros.h"
12 #include "base/strings/stringprintf.h"
13 #include "base/threading/thread_task_runner_handle.h" 12 #include "base/threading/thread_task_runner_handle.h"
14 #include "base/trace_event/trace_event.h" 13 #include "base/trace_event/trace_event.h"
15 #include "base/trace_event/trace_event_argument.h" 14 #include "base/trace_event/trace_event_argument.h"
16 #include "cc/output/begin_frame_args.h" 15 #include "cc/output/begin_frame_args.h"
17 #include "platform/RuntimeEnabledFeatures.h" 16 #include "platform/RuntimeEnabledFeatures.h"
18 #include "platform/scheduler/base/real_time_domain.h" 17 #include "platform/scheduler/base/real_time_domain.h"
19 #include "platform/scheduler/base/task_queue_impl.h" 18 #include "platform/scheduler/base/task_queue_impl.h"
20 #include "platform/scheduler/base/task_queue_selector.h" 19 #include "platform/scheduler/base/task_queue_selector.h"
21 #include "platform/scheduler/base/time_converter.h" 20 #include "platform/scheduler/base/time_converter.h"
21 #include "platform/scheduler/base/trace_helper.h"
22 #include "platform/scheduler/base/virtual_time_domain.h" 22 #include "platform/scheduler/base/virtual_time_domain.h"
23 #include "platform/scheduler/child/scheduler_tqm_delegate.h" 23 #include "platform/scheduler/child/scheduler_tqm_delegate.h"
24 #include "platform/scheduler/renderer/auto_advancing_virtual_time_domain.h" 24 #include "platform/scheduler/renderer/auto_advancing_virtual_time_domain.h"
25 #include "platform/scheduler/renderer/task_queue_throttler.h" 25 #include "platform/scheduler/renderer/task_queue_throttler.h"
26 #include "platform/scheduler/renderer/web_view_scheduler_impl.h" 26 #include "platform/scheduler/renderer/web_view_scheduler_impl.h"
27 #include "platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.h" 27 #include "platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.h"
28 #include "public/platform/Platform.h" 28 #include "public/platform/Platform.h"
29 29
30 namespace blink { 30 namespace blink {
31 namespace scheduler { 31 namespace scheduler {
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 70
71 int load_percentage = static_cast<int>(load * 100); 71 int load_percentage = static_cast<int>(load * 100);
72 DCHECK_LE(load_percentage, 100); 72 DCHECK_LE(load_percentage, 100);
73 73
74 UMA_HISTOGRAM_PERCENTAGE("RendererScheduler.BackgroundRendererMainThreadLoad", 74 UMA_HISTOGRAM_PERCENTAGE("RendererScheduler.BackgroundRendererMainThreadLoad",
75 load_percentage); 75 load_percentage);
76 TRACE_COUNTER1(TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"), 76 TRACE_COUNTER1(TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"),
77 "RendererScheduler.BackgroundRendererLoad", load_percentage); 77 "RendererScheduler.BackgroundRendererLoad", load_percentage);
78 } 78 }
79 79
80 std::string PointerToId(void* pointer) {
81 return base::StringPrintf(
82 "0x%" PRIx64,
83 static_cast<uint64_t>(reinterpret_cast<uintptr_t>(pointer)));
84 }
85
86 } // namespace 80 } // namespace
87 81
88 RendererSchedulerImpl::RendererSchedulerImpl( 82 RendererSchedulerImpl::RendererSchedulerImpl(
89 scoped_refptr<SchedulerTqmDelegate> main_task_runner) 83 scoped_refptr<SchedulerTqmDelegate> main_task_runner)
90 : helper_(main_task_runner), 84 : helper_(main_task_runner),
91 idle_helper_(&helper_, 85 idle_helper_(&helper_,
92 this, 86 this,
93 "RendererSchedulerIdlePeriod", 87 "RendererSchedulerIdlePeriod",
94 base::TimeDelta()), 88 base::TimeDelta()),
95 idle_canceled_delayed_task_sweeper_(&helper_, 89 idle_canceled_delayed_task_sweeper_(&helper_,
(...skipping 1414 matching lines...) Expand 10 before | Expand all | Expand 10 after
1510 .InMillisecondsF()); 1504 .InMillisecondsF());
1511 state->SetDouble("expected_timer_task_duration", 1505 state->SetDouble("expected_timer_task_duration",
1512 GetMainThreadOnly() 1506 GetMainThreadOnly()
1513 .timer_task_cost_estimator.expected_task_duration() 1507 .timer_task_cost_estimator.expected_task_duration()
1514 .InMillisecondsF()); 1508 .InMillisecondsF());
1515 state->SetBoolean("is_audio_playing", GetMainThreadOnly().is_audio_playing); 1509 state->SetBoolean("is_audio_playing", GetMainThreadOnly().is_audio_playing);
1516 1510
1517 state->BeginDictionary("web_view_schedulers"); 1511 state->BeginDictionary("web_view_schedulers");
1518 for (WebViewSchedulerImpl* web_view_scheduler : 1512 for (WebViewSchedulerImpl* web_view_scheduler :
1519 GetMainThreadOnly().web_view_schedulers) { 1513 GetMainThreadOnly().web_view_schedulers) {
1520 state->BeginDictionaryWithCopiedName(PointerToId(web_view_scheduler)); 1514 state->BeginDictionaryWithCopiedName(
1515 trace_helper::PointerToString(web_view_scheduler));
1521 web_view_scheduler->AsValueInto(state.get()); 1516 web_view_scheduler->AsValueInto(state.get());
1522 state->EndDictionary(); 1517 state->EndDictionary();
1523 } 1518 }
1524 state->EndDictionary(); 1519 state->EndDictionary();
1525 1520
1526 state->BeginDictionary("policy"); 1521 state->BeginDictionary("policy");
1527 GetMainThreadOnly().current_policy.AsValueInto(state.get()); 1522 GetMainThreadOnly().current_policy.AsValueInto(state.get());
1528 state->EndDictionary(); 1523 state->EndDictionary();
1529 1524
1530 // TODO(skyostil): Can we somehow trace how accurate these estimates were? 1525 // TODO(skyostil): Can we somehow trace how accurate these estimates were?
(...skipping 466 matching lines...) Expand 10 before | Expand all | Expand 10 after
1997 case TimeDomainType::VIRTUAL: 1992 case TimeDomainType::VIRTUAL:
1998 return "virtual"; 1993 return "virtual";
1999 default: 1994 default:
2000 NOTREACHED(); 1995 NOTREACHED();
2001 return nullptr; 1996 return nullptr;
2002 } 1997 }
2003 } 1998 }
2004 1999
2005 } // namespace scheduler 2000 } // namespace scheduler
2006 } // namespace blink 2001 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698