Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: third_party/WebKit/Source/platform/scheduler/base/trace_helper.h

Issue 2837323002: Merged all PointerToId functions into TraceHelper::PointerToString. (Closed)
Patch Set: Rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_BASE_TRACE_HELPER_H
6 #define THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_BASE_TRACE_HELPER_H
7
8 #include <string>
9
10 namespace blink {
11 namespace scheduler {
12
13 class TraceHelper {
jochen (gone - plz use gerrit) 2017/05/11 08:53:11 nit. should be a namespace (all static classes in
Daniel Bratell 2017/05/11 11:51:20 Done.
14 public:
15 static std::string PointerToString(const void* pointer,
16 bool add_hex_prefix = true);
jochen (gone - plz use gerrit) 2017/05/11 08:53:11 ideally that would be an enum class, no a bool
Daniel Bratell 2017/05/11 11:51:20 I have been uncertain about this flag since it's o
17 };
18
19 } // namespace scheduler
20 } // namespace blink
21
22 #endif // THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_BASE_TRACE_HELPER_H
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698