Cleanup TranslateRankerLogging experiment.

Cleanup TranslateRankerLogging experiment.

BUG=668549
Review-Url: https://codereview.chromium.org/2836333003
Cr-Commit-Position: refs/heads/master@{#471008}
Committed: https://chromium.googlesource.com/chromium/src/+/50af29853c068ae1e035aea93a98202794342da3

[hamelphi, 2017-04-25 20:03:53]

Description was changed from

==========
Cleanup TranslateRankerLogging experiment.

BUG=668549
==========

to

==========
Cleanup TranslateRankerLogging experiment.

BUG=668549
==========

[hamelphi, 2017-04-25 20:03:53]

hamelphi@chromium.org changed reviewers:
+ asvitkine@chromium.org, groby@chromium.org

[Alexei Svitkine (slow), 2017-04-28 18:08:48]

lgtm

https://codereview.chromium.org/2836333003/diff/1/components/translate/core/b...
File components/translate/core/browser/translate_ranker_impl.cc (right):

https://codereview.chromium.org/2836333003/diff/1/components/translate/core/b...
components/translate/core/browser/translate_ranker_impl.cc:141:
is_logging_enabled_(true),
Any reason not to remove the member variable at all?

[hamelphi, 2017-05-01 13:55:53]

On 2017/04/28 18:08:48, Alexei Svitkine (slow) wrote:
> lgtm
> 
>
https://codereview.chromium.org/2836333003/diff/1/components/translate/core/b...
> File components/translate/core/browser/translate_ranker_impl.cc (right):
> 
>
https://codereview.chromium.org/2836333003/diff/1/components/translate/core/b...
> components/translate/core/browser/translate_ranker_impl.cc:141:
> is_logging_enabled_(true),
> Any reason not to remove the member variable at all?

It is used to turn off logging for iOS Webview (see
https://cs.chromium.org/chromium/src/ios/web_view/internal/translate/web_view...).

[groby-ooo-7-16, 2017-05-08 15:07:15]

lgtm

[Roger McFarlane (Chromium), 2017-05-08 15:23:31]

rogerm@chromium.org changed reviewers:
+ rogerm@chromium.org

[Roger McFarlane (Chromium), 2017-05-08 15:23:31]

lgtm

[hamelphi, 2017-05-11 16:33:29]

The CQ bit was checked by hamelphi@chromium.org

[commit-bot: I haz the power, 2017-05-11 16:34:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 18:06:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494520409277450, "parent_rev":
"dedb6d42c8dfc344c00acc620b57c83ad94cbc38", "commit_rev":
"50af29853c068ae1e035aea93a98202794342da3"}

[commit-bot: I haz the power, 2017-05-11 18:06:21]

Description was changed from

==========
Cleanup TranslateRankerLogging experiment.

BUG=668549
==========

to

==========
Cleanup TranslateRankerLogging experiment.

BUG=668549

Review-Url: https://codereview.chromium.org/2836333003
Cr-Commit-Position: refs/heads/master@{#471008}
Committed:
https://chromium.googlesource.com/chromium/src/+/50af29853c068ae1e035aea93a98...
==========

[commit-bot: I haz the power, 2017-05-11 18:06:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/50af29853c068ae1e035aea93a98...