Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2836333003: Cleanup TranslateRankerLogging experiment. (Closed)

Created:
3 years, 8 months ago by hamelphi
Modified:
3 years, 7 months ago
CC:
chromium-reviews, Roger McFarlane (Chromium), yyushkina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup TranslateRankerLogging experiment. BUG=668549 Review-Url: https://codereview.chromium.org/2836333003 Cr-Commit-Position: refs/heads/master@{#471008} Committed: https://chromium.googlesource.com/chromium/src/+/50af29853c068ae1e035aea93a98202794342da3

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -49 lines) Patch
M components/translate/core/browser/translate_ranker_impl.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/translate/core/browser/translate_ranker_impl.cc View 2 chunks +1 line, -5 lines 1 comment Download
M components/translate/core/browser/translate_ranker_impl_unittest.cc View 4 chunks +1 line, -22 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
hamelphi
3 years, 7 months ago (2017-04-28 18:07:04 UTC) #3
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/2836333003/diff/1/components/translate/core/browser/translate_ranker_impl.cc File components/translate/core/browser/translate_ranker_impl.cc (right): https://codereview.chromium.org/2836333003/diff/1/components/translate/core/browser/translate_ranker_impl.cc#newcode141 components/translate/core/browser/translate_ranker_impl.cc:141: is_logging_enabled_(true), Any reason not to remove the member ...
3 years, 7 months ago (2017-04-28 18:08:48 UTC) #4
hamelphi
On 2017/04/28 18:08:48, Alexei Svitkine (slow) wrote: > lgtm > > https://codereview.chromium.org/2836333003/diff/1/components/translate/core/browser/translate_ranker_impl.cc > File components/translate/core/browser/translate_ranker_impl.cc ...
3 years, 7 months ago (2017-05-01 13:55:53 UTC) #5
groby-ooo-7-16
lgtm
3 years, 7 months ago (2017-05-08 15:07:15 UTC) #6
Roger McFarlane (Chromium)
lgtm
3 years, 7 months ago (2017-05-08 15:23:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836333003/1
3 years, 7 months ago (2017-05-11 16:34:07 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 18:06:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/50af29853c068ae1e035aea93a98...

Powered by Google App Engine
This is Rietveld 408576698