| Index: components/translate/core/browser/translate_ranker_impl_unittest.cc
|
| diff --git a/components/translate/core/browser/translate_ranker_impl_unittest.cc b/components/translate/core/browser/translate_ranker_impl_unittest.cc
|
| index 24680938933745053c7533ec03583ea111288152..dc811a10c8c4805a3695431f63ac6e7ad45e5c02 100644
|
| --- a/components/translate/core/browser/translate_ranker_impl_unittest.cc
|
| +++ b/components/translate/core/browser/translate_ranker_impl_unittest.cc
|
| @@ -34,7 +34,6 @@
|
| namespace {
|
|
|
| using translate::kTranslateRankerEnforcement;
|
| -using translate::kTranslateRankerLogging;
|
| using translate::kTranslateRankerQuery;
|
| using translate::kTranslateRankerDecisionOverride;
|
| using translate::TranslateDownloadManager;
|
| @@ -334,7 +333,6 @@ TEST_F(TranslateRankerImplTest, ShouldOfferTranslation_NoModel) {
|
| }
|
|
|
| TEST_F(TranslateRankerImplTest, RecordAndFlushEvents) {
|
| - InitFeatures({kTranslateRankerLogging}, {});
|
| std::unique_ptr<translate::TranslateRanker> ranker = GetRankerForTest(0.0f);
|
| std::vector<metrics::TranslateEventProto> flushed_events;
|
|
|
| @@ -372,26 +370,7 @@ TEST_F(TranslateRankerImplTest, RecordAndFlushEvents) {
|
| GetTestUkmService()->GetSourceForUrl(url1.spec().c_str())->url().spec());
|
| }
|
|
|
| -TEST_F(TranslateRankerImplTest, LoggingDisabled) {
|
| - InitFeatures({}, {kTranslateRankerLogging});
|
| - std::unique_ptr<translate::TranslateRanker> ranker = GetRankerForTest(0.0f);
|
| - std::vector<metrics::TranslateEventProto> flushed_events;
|
| -
|
| - ranker->FlushTranslateEvents(&flushed_events);
|
| - EXPECT_EQ(0U, flushed_events.size());
|
| -
|
| - ranker->RecordTranslateEvent(0, GURL(), &tep1_);
|
| - ranker->RecordTranslateEvent(1, GURL(), &tep2_);
|
| - ranker->RecordTranslateEvent(2, GURL(), &tep3_);
|
| -
|
| - // Logging is disabled, so no events should be cached.
|
| - ranker->FlushTranslateEvents(&flushed_events);
|
| - EXPECT_EQ(0U, flushed_events.size());
|
| - EXPECT_EQ(0ul, GetTestUkmService()->sources_count());
|
| -}
|
| -
|
| TEST_F(TranslateRankerImplTest, LoggingDisabledViaOverride) {
|
| - InitFeatures({kTranslateRankerLogging}, {});
|
| std::unique_ptr<translate::TranslateRankerImpl> ranker =
|
| GetRankerForTest(0.0f);
|
| std::vector<metrics::TranslateEventProto> flushed_events;
|
| @@ -403,7 +382,7 @@ TEST_F(TranslateRankerImplTest, LoggingDisabledViaOverride) {
|
| ranker->RecordTranslateEvent(1, GURL(), &tep2_);
|
| ranker->RecordTranslateEvent(2, GURL(), &tep3_);
|
|
|
| - // Logging is disabled, so no events should be cached.
|
| + // Logging is enabled by default, so events should be cached.
|
| ranker->FlushTranslateEvents(&flushed_events);
|
| EXPECT_EQ(3U, flushed_events.size());
|
|
|
|
|