Cleanup TranslateRankerLogging experiment.

components/translate/core/browser/translate_ranker_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/translate/core/browser/translate_ranker_impl.h"
 
 #include <initializer_list>
 #include <memory>
 
 #include "base/feature_list.h"
@@ skipping 16 matching lines @@
 #include "components/ukm/test_ukm_service.h"
 #include "components/ukm/ukm_source.h"
 #include "net/url_request/test_url_fetcher_factory.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 namespace {
 
 using translate::kTranslateRankerEnforcement;
-using translate::kTranslateRankerLogging;
 using translate::kTranslateRankerQuery;
 using translate::kTranslateRankerDecisionOverride;
 using translate::TranslateDownloadManager;
 using translate::TranslateRankerFeatures;
 using translate::TranslatePrefs;
 using translate::TranslateRankerImpl;
 
 constexpr uint32_t kModelVersion = 1234;
 
 class TranslateRankerImplTest : public ::testing::Test {
@@ skipping 279 matching lines @@
   metrics::TranslateEventProto tep;
   // If we don't have a model, returns true.
   EXPECT_TRUE(
       ranker->ShouldOfferTranslation(*translate_prefs_, "en", "fr", &tep));
   EXPECT_NE(0U, tep.ranker_request_timestamp_sec());
   EXPECT_EQ(0U, tep.ranker_version());
   EXPECT_EQ(metrics::TranslateEventProto::NOT_QUERIED, tep.ranker_response());
 }
 
 TEST_F(TranslateRankerImplTest, RecordAndFlushEvents) {
-  InitFeatures({kTranslateRankerLogging}, {});
   std::unique_ptr<translate::TranslateRanker> ranker = GetRankerForTest(0.0f);
   std::vector<metrics::TranslateEventProto> flushed_events;
 
   GURL url0("https://www.google.com");
   GURL url1("https://www.gmail.com");
 
   // Check that flushing an empty cache will return an empty vector.
   ranker->FlushTranslateEvents(&flushed_events);
   EXPECT_EQ(0U, flushed_events.size());
 
@@ skipping 17 matching lines @@
 
   ASSERT_EQ(2U, GetTestUkmService()->sources_count());
   EXPECT_EQ(
       url0.spec(),
       GetTestUkmService()->GetSourceForUrl(url0.spec().c_str())->url().spec());
   EXPECT_EQ(
       url1.spec(),
       GetTestUkmService()->GetSourceForUrl(url1.spec().c_str())->url().spec());
 }
 
-TEST_F(TranslateRankerImplTest, LoggingDisabled) {
-  InitFeatures({}, {kTranslateRankerLogging});
-  std::unique_ptr<translate::TranslateRanker> ranker = GetRankerForTest(0.0f);
-  std::vector<metrics::TranslateEventProto> flushed_events;
-
-  ranker->FlushTranslateEvents(&flushed_events);
-  EXPECT_EQ(0U, flushed_events.size());
-
-  ranker->RecordTranslateEvent(0, GURL(), &tep1_);
-  ranker->RecordTranslateEvent(1, GURL(), &tep2_);
-  ranker->RecordTranslateEvent(2, GURL(), &tep3_);
-
-  // Logging is disabled, so no events should be cached.
-  ranker->FlushTranslateEvents(&flushed_events);
-  EXPECT_EQ(0U, flushed_events.size());
-  EXPECT_EQ(0ul, GetTestUkmService()->sources_count());
-}
-
 TEST_F(TranslateRankerImplTest, LoggingDisabledViaOverride) {
-  InitFeatures({kTranslateRankerLogging}, {});
   std::unique_ptr<translate::TranslateRankerImpl> ranker =
       GetRankerForTest(0.0f);
   std::vector<metrics::TranslateEventProto> flushed_events;
 
   ranker->FlushTranslateEvents(&flushed_events);
   EXPECT_EQ(0U, flushed_events.size());
 
   ranker->RecordTranslateEvent(0, GURL(), &tep1_);
   ranker->RecordTranslateEvent(1, GURL(), &tep2_);
   ranker->RecordTranslateEvent(2, GURL(), &tep3_);
 
-  // Logging is disabled, so no events should be cached.
+  // Logging is enabled by default, so events should be cached.
   ranker->FlushTranslateEvents(&flushed_events);
   EXPECT_EQ(3U, flushed_events.size());
 
   // Override the feature setting to disable logging.
   ranker->EnableLogging(false);
 
   ranker->RecordTranslateEvent(0, GURL(), &tep1_);
   ranker->RecordTranslateEvent(1, GURL(), &tep2_);
   ranker->RecordTranslateEvent(2, GURL(), &tep3_);
 
@@ skipping 28 matching lines @@
   EXPECT_TRUE(ranker->ShouldOverrideDecision(2, GURL(), &tep));
 
   std::vector<metrics::TranslateEventProto> flushed_events;
   ranker->FlushTranslateEvents(&flushed_events);
   EXPECT_EQ(0U, flushed_events.size());
   ASSERT_EQ(2, tep.decision_overrides_size());
   ASSERT_EQ(1, tep.decision_overrides(0));
   ASSERT_EQ(2, tep.decision_overrides(1));
   ASSERT_EQ(0, tep.event_type());
 }