Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: components/translate/core/browser/translate_ranker_impl.cc

Issue 2836333003: Cleanup TranslateRankerLogging experiment. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/translate/core/browser/translate_ranker_impl.h" 5 #include "components/translate/core/browser/translate_ranker_impl.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 } 75 }
76 76
77 } // namespace 77 } // namespace
78 78
79 const base::Feature kTranslateRankerQuery{"TranslateRankerQuery", 79 const base::Feature kTranslateRankerQuery{"TranslateRankerQuery",
80 base::FEATURE_DISABLED_BY_DEFAULT}; 80 base::FEATURE_DISABLED_BY_DEFAULT};
81 81
82 const base::Feature kTranslateRankerEnforcement{ 82 const base::Feature kTranslateRankerEnforcement{
83 "TranslateRankerEnforcement", base::FEATURE_DISABLED_BY_DEFAULT}; 83 "TranslateRankerEnforcement", base::FEATURE_DISABLED_BY_DEFAULT};
84 84
85 const base::Feature kTranslateRankerLogging{"TranslateRankerLogging",
86 base::FEATURE_ENABLED_BY_DEFAULT};
87
88 const base::Feature kTranslateRankerDecisionOverride{ 85 const base::Feature kTranslateRankerDecisionOverride{
89 "TranslateRankerDecisionOverride", base::FEATURE_DISABLED_BY_DEFAULT}; 86 "TranslateRankerDecisionOverride", base::FEATURE_DISABLED_BY_DEFAULT};
90 87
91 TranslateRankerFeatures::TranslateRankerFeatures() {} 88 TranslateRankerFeatures::TranslateRankerFeatures() {}
92 89
93 TranslateRankerFeatures::TranslateRankerFeatures(int accepted, 90 TranslateRankerFeatures::TranslateRankerFeatures(int accepted,
94 int denied, 91 int denied,
95 int ignored, 92 int ignored,
96 const std::string& src, 93 const std::string& src,
97 const std::string& dst, 94 const std::string& dst,
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 << "total_count=" << total_count << ", " 131 << "total_count=" << total_count << ", "
135 << "accept_ratio=" << accepted_ratio << ", " 132 << "accept_ratio=" << accepted_ratio << ", "
136 << "decline_ratio=" << denied_ratio << ", " 133 << "decline_ratio=" << denied_ratio << ", "
137 << "ignore_ratio=" << ignored_ratio; 134 << "ignore_ratio=" << ignored_ratio;
138 } 135 }
139 136
140 TranslateRankerImpl::TranslateRankerImpl(const base::FilePath& model_path, 137 TranslateRankerImpl::TranslateRankerImpl(const base::FilePath& model_path,
141 const GURL& model_url, 138 const GURL& model_url,
142 ukm::UkmService* ukm_service) 139 ukm::UkmService* ukm_service)
143 : ukm_service_(ukm_service), 140 : ukm_service_(ukm_service),
144 is_logging_enabled_( 141 is_logging_enabled_(true),
Alexei Svitkine (slow) 2017/04/28 18:08:47 Any reason not to remove the member variable at al
145 base::FeatureList::IsEnabled(kTranslateRankerLogging)),
146 is_query_enabled_(base::FeatureList::IsEnabled(kTranslateRankerQuery)), 142 is_query_enabled_(base::FeatureList::IsEnabled(kTranslateRankerQuery)),
147 is_enforcement_enabled_( 143 is_enforcement_enabled_(
148 base::FeatureList::IsEnabled(kTranslateRankerEnforcement)), 144 base::FeatureList::IsEnabled(kTranslateRankerEnforcement)),
149 is_decision_override_enabled_(base::FeatureList::IsEnabled( 145 is_decision_override_enabled_(base::FeatureList::IsEnabled(
150 translate::kTranslateRankerDecisionOverride)), 146 translate::kTranslateRankerDecisionOverride)),
151 weak_ptr_factory_(this) { 147 weak_ptr_factory_(this) {
152 if (is_query_enabled_ || is_enforcement_enabled_ || 148 if (is_query_enabled_ || is_enforcement_enabled_ ||
153 is_decision_override_enabled_) { 149 is_decision_override_enabled_) {
154 model_loader_ = base::MakeUnique<RankerModelLoader>( 150 model_loader_ = base::MakeUnique<RankerModelLoader>(
155 base::Bind(&ValidateModel), 151 base::Bind(&ValidateModel),
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
373 } 369 }
374 } 370 }
375 371
376 } // namespace translate 372 } // namespace translate
377 373
378 std::ostream& operator<<(std::ostream& stream, 374 std::ostream& operator<<(std::ostream& stream,
379 const translate::TranslateRankerFeatures& features) { 375 const translate::TranslateRankerFeatures& features) {
380 features.WriteTo(stream); 376 features.WriteTo(stream);
381 return stream; 377 return stream;
382 } 378 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698