Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: components/translate/core/browser/translate_ranker_impl.cc

Issue 2836333003: Cleanup TranslateRankerLogging experiment. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_ranker_impl.cc
diff --git a/components/translate/core/browser/translate_ranker_impl.cc b/components/translate/core/browser/translate_ranker_impl.cc
index 906c498f964e219b6a57fecbed801ee529d65ae7..ebd3f923b278e8106f8204d0c7b14a71d28dd9c0 100644
--- a/components/translate/core/browser/translate_ranker_impl.cc
+++ b/components/translate/core/browser/translate_ranker_impl.cc
@@ -82,9 +82,6 @@ const base::Feature kTranslateRankerQuery{"TranslateRankerQuery",
const base::Feature kTranslateRankerEnforcement{
"TranslateRankerEnforcement", base::FEATURE_DISABLED_BY_DEFAULT};
-const base::Feature kTranslateRankerLogging{"TranslateRankerLogging",
- base::FEATURE_ENABLED_BY_DEFAULT};
-
const base::Feature kTranslateRankerDecisionOverride{
"TranslateRankerDecisionOverride", base::FEATURE_DISABLED_BY_DEFAULT};
@@ -141,8 +138,7 @@ TranslateRankerImpl::TranslateRankerImpl(const base::FilePath& model_path,
const GURL& model_url,
ukm::UkmService* ukm_service)
: ukm_service_(ukm_service),
- is_logging_enabled_(
- base::FeatureList::IsEnabled(kTranslateRankerLogging)),
+ is_logging_enabled_(true),
Alexei Svitkine (slow) 2017/04/28 18:08:47 Any reason not to remove the member variable at al
is_query_enabled_(base::FeatureList::IsEnabled(kTranslateRankerQuery)),
is_enforcement_enabled_(
base::FeatureList::IsEnabled(kTranslateRankerEnforcement)),

Powered by Google App Engine
This is Rietveld 408576698