Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2834463002: Move CreateDOMException out of V8ThrowException (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by adithyas
Modified:
3 months, 4 weeks ago
Reviewers:
haraken, jbroman
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, haraken, jbroman+watch_chromium.org, mlamouri+watch-blink_chromium.org, Srirama
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move CreateDOMException out of V8ThrowException This CL moves CreateDOMException into V8ThrowDOMException (a new file). V8ThrowDOMException will remain in bindings/core while V8ThrowException can move to platform/bindings. BUG=682322 Review-Url: https://codereview.chromium.org/2834463002 Cr-Commit-Position: refs/heads/master@{#466124} Committed: https://chromium.googlesource.com/chromium/src/+/859c80fc6fb5fa8b8a0684955a2829dfc66b3a5b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -99 lines) Patch
M third_party/WebKit/Source/bindings/bindings.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ExceptionState.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/bindings/core/v8/V8ThrowDOMException.h View 1 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/bindings/core/v8/V8ThrowDOMException.cpp View 1 chunk +94 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h View 1 1 chunk +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ThrowException.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 14 (9 generated)
adithyas
4 months ago (2017-04-19 22:11:20 UTC) #6
haraken
LGTM https://codereview.chromium.org/2834463002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8ThrowDOMException.h File third_party/WebKit/Source/bindings/core/v8/V8ThrowDOMException.h (right): https://codereview.chromium.org/2834463002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8ThrowDOMException.h#newcode16 third_party/WebKit/Source/bindings/core/v8/V8ThrowDOMException.h:16: class CORE_EXPORT V8ThrowDOMException { Add a class-level comment? ...
4 months ago (2017-04-19 22:15:10 UTC) #7
jbroman
lgtm too (though it's a little weird for DOMException stuff is used for non-DOMException errors)
3 months, 4 weeks ago (2017-04-20 17:23:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834463002/20001
3 months, 4 weeks ago (2017-04-20 17:35:48 UTC) #11
commit-bot: I haz the power
3 months, 4 weeks ago (2017-04-20 20:55:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/859c80fc6fb5fa8b8a0684955a28...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b