third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp - Issue 2834463002: Move CreateDOMException out of V8ThrowException

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp

Issue 2834463002: Move CreateDOMException out of V8ThrowException (Closed)

Patch Set: Add comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8ThrowException.cpp ('k') | third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp

index eb24a7d09f220b7804287a1e90646e267d54b288..bc0cf537a4dc95ecaf9d688e8606827c6bc92aa8 100644

--- a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp

@@ -14,6 +14,7 @@

#include "bindings/core/v8/V8MessagePort.h"

#include "bindings/core/v8/V8OffscreenCanvas.h"

#include "bindings/core/v8/V8SharedArrayBuffer.h"

+#include "bindings/core/v8/V8ThrowDOMException.h"

#include "core/dom/DOMArrayBufferBase.h"

#include "core/html/ImageData.h"

#include "platform/RuntimeEnabledFeatures.h"

@@ -363,9 +364,8 @@ void V8ScriptValueSerializer::ThrowDataCloneError(

DCHECK(exception_state_);

String message = exception_state_->AddExceptionContext(

V8StringToWebCoreString<String>(v8_message, kDoNotExternalize));

- v8::Local<v8::Value> exception = V8ThrowException::CreateDOMException(

- script_state_->GetIsolate(), kDataCloneError, message);

- V8ThrowException::ThrowException(script_state_->GetIsolate(), exception);

+ V8ThrowDOMException::ThrowDOMException(script_state_->GetIsolate(),

+ kDataCloneError, message);

}

v8::Maybe<bool> V8ScriptValueSerializer::WriteHostObject(