Move CreateDOMException out of V8ThrowException

Move CreateDOMException out of V8ThrowException

This CL moves CreateDOMException into V8ThrowDOMException (a new file). V8ThrowDOMException will remain in bindings/core while V8ThrowException can move to platform/bindings.

BUG=682322
Review-Url: https://codereview.chromium.org/2834463002
Cr-Commit-Position: refs/heads/master@{#466124}
Committed: https://chromium.googlesource.com/chromium/src/+/859c80fc6fb5fa8b8a0684955a2829dfc66b3a5b

[adithyas, 2017-04-19 17:47:29]

The CQ bit was checked by adithyas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 17:48:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 20:49:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 20:49:40]

Dry run: This issue passed the CQ dry run.

[adithyas, 2017-04-19 22:11:19]

adithyas@chromium.org changed reviewers:
+ haraken@chromium.org, jbroman@chromium.org

[haraken, 2017-04-19 22:15:10]

LGTM

https://codereview.chromium.org/2834463002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8ThrowDOMException.h (right):

https://codereview.chromium.org/2834463002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8ThrowDOMException.h:16: class
CORE_EXPORT V8ThrowDOMException {

Add a class-level comment?

https://codereview.chromium.org/2834463002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h (right):

https://codereview.chromium.org/2834463002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h:36: // Mostly a
set of wrapper functions for v8::Exception class.

Reword a class-level comment. V8ThrowException is a class to throw JS built-in
errors and V8ThrowDOMException is a class to throw DOMExceptions (in the spec
terms).

[jbroman, 2017-04-20 17:23:29]

lgtm too (though it's a little weird for DOMException stuff is used for
non-DOMException errors)

[adithyas, 2017-04-20 17:35:26]

The CQ bit was checked by adithyas@chromium.org

[adithyas, 2017-04-20 17:35:26]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2834463002/#ps20001
(title: "Add comments")

[commit-bot: I haz the power, 2017-04-20 17:35:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 20:55:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492709726564410,
"parent_rev": "e02d5f6605d5ceabeb3f5cd4a84495a54e1f3fce", "commit_rev":
"859c80fc6fb5fa8b8a0684955a2829dfc66b3a5b"}

[commit-bot: I haz the power, 2017-04-20 20:55:25]

Description was changed from

==========
Move CreateDOMException out of V8ThrowException

This CL moves CreateDOMException into V8ThrowDOMException (a new file).
V8ThrowDOMException will remain in bindings/core while V8ThrowException can move
to platform/bindings.

BUG=682322
==========

to

==========
Move CreateDOMException out of V8ThrowException

This CL moves CreateDOMException into V8ThrowDOMException (a new file).
V8ThrowDOMException will remain in bindings/core while V8ThrowException can move
to platform/bindings.

BUG=682322

Review-Url: https://codereview.chromium.org/2834463002
Cr-Commit-Position: refs/heads/master@{#466124}
Committed:
https://chromium.googlesource.com/chromium/src/+/859c80fc6fb5fa8b8a0684955a28...
==========

[commit-bot: I haz the power, 2017-04-20 20:55:27]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/859c80fc6fb5fa8b8a0684955a28...