Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp

Issue 2834463002: Move CreateDOMException out of V8ThrowException (Closed)
Patch Set: Add comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp b/third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp
index 9ca54a356341c23b88b2f35d83ef5089a1ba455b..73727144668884127305509b827327cd8d9a14b5 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp
@@ -32,8 +32,7 @@
#include "bindings/core/v8/ExceptionMessages.h"
#include "bindings/core/v8/ScriptPromiseResolver.h"
-#include "bindings/core/v8/V8ThrowException.h"
-#include "core/dom/ExceptionCode.h"
+#include "bindings/core/v8/V8ThrowDOMException.h"
namespace blink {
@@ -64,7 +63,7 @@ void ExceptionState::ThrowDOMException(ExceptionCode ec,
const String& processed_message = AddExceptionContext(message);
SetException(
ec, processed_message,
- V8ThrowException::CreateDOMException(isolate_, ec, processed_message));
+ V8ThrowDOMException::CreateDOMException(isolate_, ec, processed_message));
}
void ExceptionState::ThrowRangeError(const String& message) {
@@ -79,8 +78,8 @@ void ExceptionState::ThrowSecurityError(const String& sanitized_message,
const String& final_unsanitized = AddExceptionContext(unsanitized_message);
SetException(
kSecurityError, final_sanitized,
- V8ThrowException::CreateDOMException(isolate_, kSecurityError,
- final_sanitized, final_unsanitized));
+ V8ThrowDOMException::CreateDOMException(
+ isolate_, kSecurityError, final_sanitized, final_unsanitized));
}
void ExceptionState::ThrowTypeError(const String& message) {

Powered by Google App Engine
This is Rietveld 408576698