Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

Issue 2834463002: Move CreateDOMException out of V8ThrowException (Closed)
Patch Set: Add comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
index 8382d22ad1110f6abc6e82d37fd3b254a61f30c6..ca09ccc7729380b6bdb6fde77bc79dfb1d281cf1 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
@@ -12,7 +12,7 @@
#include "bindings/core/v8/V8ErrorHandler.h"
#include "bindings/core/v8/V8PrivateProperty.h"
#include "bindings/core/v8/V8ScriptRunner.h"
-#include "bindings/core/v8/V8ThrowException.h"
+#include "bindings/core/v8/V8ThrowDOMException.h"
#include "core/dom/ExceptionCode.h"
#include "core/dom/ExecutionContext.h"
#include "core/dom/custom/CustomElement.h"
@@ -259,7 +259,7 @@ bool ScriptCustomElementDefinition::RunConstructor(Element* element) {
const String& message =
"custom element constructors must call super() first and must "
"not return a different object";
- v8::Local<v8::Value> exception = V8ThrowException::CreateDOMException(
+ v8::Local<v8::Value> exception = V8ThrowDOMException::CreateDOMException(
script_state_->GetIsolate(), kInvalidStateError, message);
DispatchErrorEvent(isolate, exception, Constructor());
return false;

Powered by Google App Engine
This is Rietveld 408576698