Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2829543002: [DMC #5] Add SpellCheckMarkerListImpl (Closed)

Created:
3 years, 8 months ago by rlanday
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SpellCheckMarkerListImpl This marker list implementation can be used for Spelling and Grammar markers. It maintains the markers in a sorted list and merges markers whose endpoints touch. I'm moving RemoveMarkersUnderWords() from DocumentMarkerList to only be on SpellCheckMarkerListImpl in this CL and adding a cast in DocumentMarkerController to enable this. BUG=707867 Review-Url: https://codereview.chromium.org/2829543002 Cr-Commit-Position: refs/heads/master@{#470847} Committed: https://chromium.googlesource.com/chromium/src/+/5107b8dc6ef983872e59f544f14fb68434025cf0

Patch Set 1 #

Patch Set 2 : Remove type casts that aren't currently needed #

Patch Set 3 : Rebase, add test for RemoveMarkersUnderWords() #

Patch Set 4 : Convert DoesNotOverlap to lambda for consistency #

Patch Set 5 : Rebase, add comments #

Patch Set 6 : Use DocumentMarkerListEditor::AddMarkerAndMergeOverlapping() #

Patch Set 7 : Clean up DocumentMarkerList/GenericDMLImpl #

Total comments: 6

Patch Set 8 : Respond to comments #

Patch Set 9 : Actually use DMLEditor implementation in SpellCheckMarkerListImpl::Add() #

Patch Set 10 : Leave method implementations in DocumentMarkerListEditor but change signatures #

Total comments: 5

Patch Set 11 : Add TODOs #

Patch Set 12 : Don't update DocumentMarkerControllerTest in this CL #

Total comments: 3

Patch Set 13 : Add newline before DECLARE_VIRTUAL_TRACE(), split off RemoveMarkesrUnderWords() changes #

Patch Set 14 : Remove comment about RemoveMarkersUnderWords() being SpellCheckMarkerListImpl-specific (it's not ye… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -18 lines) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/CompositionMarkerListImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +14 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -2 lines 0 comments Download
A third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImplTest.cpp View 1 2 1 chunk +150 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 84 (58 generated)
rlanday
3 years, 8 months ago (2017-04-19 02:17:01 UTC) #4
Xiaocheng
https://codereview.chromium.org/2829543002/diff/120001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp File third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp (left): https://codereview.chromium.org/2829543002/diff/120001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp#oldcode85 third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp:85: bool DocumentMarkerListEditor::RemoveMarkersUnderWords( Could you modify this function in-place, and ...
3 years, 7 months ago (2017-04-27 19:04:02 UTC) #30
rlanday
https://codereview.chromium.org/2829543002/diff/120001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp File third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp (left): https://codereview.chromium.org/2829543002/diff/120001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp#oldcode131 third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp:131: void DocumentMarkerListEditor::AddMarkerAndMergeOverlapping( On 2017/04/27 at 19:04:01, Xiaocheng wrote: > ...
3 years, 7 months ago (2017-04-27 20:30:13 UTC) #31
rlanday
Updated
3 years, 7 months ago (2017-04-27 20:44:05 UTC) #34
rlanday
Updated again after talking with xiaochengh
3 years, 7 months ago (2017-04-27 21:30:23 UTC) #40
Xiaocheng
Thanks. No more comments other than those inlined below. https://codereview.chromium.org/2829543002/diff/180001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp File third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp (left): https://codereview.chromium.org/2829543002/diff/180001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp#oldcode75 third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp:75: ...
3 years, 7 months ago (2017-04-27 22:04:38 UTC) #42
rlanday
https://codereview.chromium.org/2829543002/diff/180001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp File third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp (left): https://codereview.chromium.org/2829543002/diff/180001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp#oldcode75 third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp:75: MarkerController().AddMarker(range.StartPosition(), range.EndPosition(), On 2017/04/27 at 22:04:38, Xiaocheng wrote: > ...
3 years, 7 months ago (2017-04-27 22:22:23 UTC) #43
rlanday
On 2017/04/27 at 22:22:23, rlanday wrote: > No, these are actually correctly creating Spelling markers, ...
3 years, 7 months ago (2017-04-27 22:27:12 UTC) #45
Xiaocheng
On 2017/04/27 at 22:22:23, rlanday wrote: > https://codereview.chromium.org/2829543002/diff/180001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp > File third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp (left): > > https://codereview.chromium.org/2829543002/diff/180001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp#oldcode75 ...
3 years, 7 months ago (2017-04-28 18:21:40 UTC) #49
rlanday
On 2017/04/28 at 18:21:40, xiaochengh wrote: > Please do this later when cleaning up RenderedRect/RenderedDocumentMarker-related ...
3 years, 7 months ago (2017-04-28 18:31:48 UTC) #51
Xiaocheng
lgtm
3 years, 7 months ago (2017-04-28 18:45:04 UTC) #55
yosin_UTC9
https://codereview.chromium.org/2829543002/diff/220001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp (right): https://codereview.chromium.org/2829543002/diff/220001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp#newcode519 third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:519: static_cast<SpellCheckMarkerListImpl* const>(list) nit: s/ const// We should use DEFINE_TYPE_CAST(), ...
3 years, 7 months ago (2017-05-08 04:50:55 UTC) #56
rlanday
On 2017/05/08 at 04:50:55, yosin wrote: > https://codereview.chromium.org/2829543002/diff/220001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp > File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp (right): > > https://codereview.chromium.org/2829543002/diff/220001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp#newcode519 ...
3 years, 7 months ago (2017-05-08 19:04:27 UTC) #57
rlanday
Ok, I've removed the RemoveMarkersUnderWords() changes from this CL
3 years, 7 months ago (2017-05-08 20:55:21 UTC) #58
Xiaocheng
still looks good.
3 years, 7 months ago (2017-05-08 22:13:46 UTC) #61
Xiaocheng
On 2017/05/08 at 22:13:46, Xiaocheng wrote: > still looks good. What's your current plan for ...
3 years, 7 months ago (2017-05-08 22:15:18 UTC) #62
rlanday
On 2017/05/08 at 22:15:18, xiaochengh wrote: > On 2017/05/08 at 22:13:46, Xiaocheng wrote: > > ...
3 years, 7 months ago (2017-05-08 23:51:43 UTC) #65
yosin_UTC9
lgtm Thanks!
3 years, 7 months ago (2017-05-09 01:34:12 UTC) #66
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829543002/260001
3 years, 7 months ago (2017-05-09 17:23:45 UTC) #69
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/335549)
3 years, 7 months ago (2017-05-09 23:10:20 UTC) #71
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829543002/260001
3 years, 7 months ago (2017-05-10 17:15:41 UTC) #73
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450384)
3 years, 7 months ago (2017-05-10 20:14:46 UTC) #75
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829543002/260001
3 years, 7 months ago (2017-05-10 23:22:16 UTC) #77
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451095)
3 years, 7 months ago (2017-05-11 03:55:43 UTC) #79
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829543002/260001
3 years, 7 months ago (2017-05-11 03:59:06 UTC) #81
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 06:36:46 UTC) #84
Message was sent while issue was closed.
Committed patchset #14 (id:260001) as
https://chromium.googlesource.com/chromium/src/+/5107b8dc6ef983872e59f544f14f...

Powered by Google App Engine
This is Rietveld 408576698