Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

Issue 2829543002: [DMC #5] Add SpellCheckMarkerListImpl (Closed)
Patch Set: Don't update DocumentMarkerControllerTest in this CL Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DocumentMarkerList_h 5 #ifndef DocumentMarkerList_h
6 #define DocumentMarkerList_h 6 #define DocumentMarkerList_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "platform/heap/Handle.h" 9 #include "platform/heap/Handle.h"
10 10
(...skipping 19 matching lines...) Expand all
30 30
31 virtual const HeapVector<Member<RenderedDocumentMarker>>& GetMarkers() 31 virtual const HeapVector<Member<RenderedDocumentMarker>>& GetMarkers()
32 const = 0; 32 const = 0;
33 33
34 // Returns true if at least one marker is copied, false otherwise 34 // Returns true if at least one marker is copied, false otherwise
35 virtual bool MoveMarkers(int length, DocumentMarkerList* dst_list) = 0; 35 virtual bool MoveMarkers(int length, DocumentMarkerList* dst_list) = 0;
36 36
37 // Returns true if at least one marker is removed, false otherwise 37 // Returns true if at least one marker is removed, false otherwise
38 virtual bool RemoveMarkers(unsigned start_offset, int length) = 0; 38 virtual bool RemoveMarkers(unsigned start_offset, int length) = 0;
39 39
40 // Returns true if a marker was removed, false otherwise.
41 // TODO(rlanday): remove this method from this interface once we have a
42 // Spelling/Grammar-specific marker list impl to put this on
43 virtual bool RemoveMarkersUnderWords(const String& node_text,
yosin_UTC9 2017/05/08 04:50:54 Could you make this patch into two patches? 1. Int
44 const Vector<String>& words) = 0;
45
46 // Returns true if at least one marker is shifted or removed, false otherwise 40 // Returns true if at least one marker is shifted or removed, false otherwise
47 virtual bool ShiftMarkers(unsigned offset, 41 virtual bool ShiftMarkers(unsigned offset,
48 unsigned old_length, 42 unsigned old_length,
49 unsigned new_length) = 0; 43 unsigned new_length) = 0;
50 44
51 DEFINE_INLINE_VIRTUAL_TRACE() {} 45 DEFINE_INLINE_VIRTUAL_TRACE() {}
52 46
53 protected: 47 protected:
54 DocumentMarkerList(); 48 DocumentMarkerList();
55 49
56 private: 50 private:
57 DISALLOW_COPY_AND_ASSIGN(DocumentMarkerList); 51 DISALLOW_COPY_AND_ASSIGN(DocumentMarkerList);
58 }; 52 };
59 53
60 } // namespace blink 54 } // namespace blink
61 55
62 #endif // DocumentMarkerList_h 56 #endif // DocumentMarkerList_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698