third_party/WebKit/Source/core/editing/markers/CompositionMarkerListImpl.cpp - Issue 2829543002: [DMC #5] Add SpellCheckMarkerListImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/CompositionMarkerListImpl.cpp

Issue 2829543002: [DMC #5] Add SpellCheckMarkerListImpl (Closed)

Patch Set: Remove comment about RemoveMarkersUnderWords() being SpellCheckMarkerListImpl-specific (it's not ye… Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/BUILD.gn ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/CompositionMarkerListImpl.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/CompositionMarkerListImpl.cpp b/third_party/WebKit/Source/core/editing/markers/CompositionMarkerListImpl.cpp

index 3d46d50573f92cc3263db9c587ab2266c19ee4d6..07142eae7f3e9ab851b42b714c4bf544604229c3 100644

--- a/third_party/WebKit/Source/core/editing/markers/CompositionMarkerListImpl.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/CompositionMarkerListImpl.cpp

@@ -41,9 +41,9 @@ bool CompositionMarkerListImpl::RemoveMarkers(unsigned start_offset,

bool CompositionMarkerListImpl::RemoveMarkersUnderWords(

const String& node_text,

const Vector<String>& words) {

- // This method will be removed from the DocumentMarkerList interface once

- // SpellCheckMatchMarkerListImpl is added. DocumentMarkerController shouldn't

- // try to call it on a list storing Composition markers.

+ // This method will be removed from the DocumentMarkerList interface in a

+ // later CL. SpellCheckMatchMarkerListImpl is added. DocumentMarkerController

+ // shouldn't try to call it on a list storing Composition markers.

NOTREACHED();

return false;

}