[DMC #5.5] Move SpellCheckMarkerListImpl::Add() implementation from DMLEditor.cpp

Move SpellCheckMarkerListImpl::Add() implementation from DMLEditor.cpp

Move SpellCheckMarkerListImpl::Add() from DocumentMarkerListEditor.cpp to
SpellCheckMarkerListImpl.cpp. This method implementation was left in
DocumentMarkerListEditor in https://codereview.chromium.org/2829543002
to make that patch smaller. This patch moves it to its final location.

BUG=707867
Review-Url: https://codereview.chromium.org/2851633003
Cr-Commit-Position: refs/heads/master@{#471229}
Committed: https://chromium.googlesource.com/chromium/src/+/01d3e7ab39cb3238de4950601fb92c81ca4e67d7

[rlanday, 2017-04-27 21:50:17]

Description was changed from

==========
Move SpellCheckMarkerListImpl method implementations from DMLEditor.cpp

BUG=707867
==========

to

==========
Move SpellCheckMarkerListImpl method implementations from DMLEditor.cpp

Move SpellCheckMarkerListImpl method implementations for Add() and
RemoveMarkersUnderWords() from DocumentMarkerListEditor.cpp to 
SpellCheckMarkerListImpl.cpp. These method implementations were left in
DocumentMarkerListEditor in https://codereview.chromium.org/2829543002
to make that patch smaller. This patch moves them to their final locations.

BUG=707867
==========

[rlanday, 2017-04-27 21:50:17]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[Xiaocheng, 2017-04-28 18:45:11]

lgtm

[rlanday, 2017-05-08 21:12:13]

Description was changed from

==========
Move SpellCheckMarkerListImpl method implementations from DMLEditor.cpp

Move SpellCheckMarkerListImpl method implementations for Add() and
RemoveMarkersUnderWords() from DocumentMarkerListEditor.cpp to 
SpellCheckMarkerListImpl.cpp. These method implementations were left in
DocumentMarkerListEditor in https://codereview.chromium.org/2829543002
to make that patch smaller. This patch moves them to their final locations.

BUG=707867
==========

to

==========
Move SpellCheckMarkerListImpl::Add() implementation from DMLEditor.cpp

Move SpellCheckMarkerListImpl::Add() from DocumentMarkerListEditor.cpp to
SpellCheckMarkerListImpl.cpp. This method implementation was left in
DocumentMarkerListEditor in https://codereview.chromium.org/2829543002
to make that patch smaller. This patch moves it to its final location.

BUG=707867
==========

[yosin_UTC9, 2017-05-10 06:27:25]

lgtm

[Xiaocheng, 2017-05-10 18:25:57]

I think this CL needs rebasing.

[rlanday, 2017-05-10 19:10:01]

On 2017/05/10 at 18:25:57, xiaochengh wrote:
> I think this CL needs rebasing.

It seems to match what I have locally, are you sure?

[rlanday, 2017-05-10 19:11:27]

On 2017/05/10 at 19:10:01, rlanday wrote:
> On 2017/05/10 at 18:25:57, xiaochengh wrote:
> > I think this CL needs rebasing.
> 
> It seems to match what I have locally, are you sure?

Ohh I think the RemoveMarkersUnderWords() changes are not supposed to be in
here...

[rlanday, 2017-05-11 15:49:02]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-05-11 15:49:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
xiaochengh@chromium.org, yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2851633003/#ps60001
(title: "Remove RemoveMarkersUnderWords() changes that are not supposed to be in
this CL")

[commit-bot: I haz the power, 2017-05-11 15:49:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 17:39:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 17:39:23]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2017-05-12 04:45:25]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-05-12 04:45:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 05:35:51]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494564325591130,
"parent_rev": "79067c775b1196aa0be445effa8109d85ca82b68", "commit_rev":
"01d3e7ab39cb3238de4950601fb92c81ca4e67d7"}

[commit-bot: I haz the power, 2017-05-12 05:36:01]

Description was changed from

==========
Move SpellCheckMarkerListImpl::Add() implementation from DMLEditor.cpp

Move SpellCheckMarkerListImpl::Add() from DocumentMarkerListEditor.cpp to
SpellCheckMarkerListImpl.cpp. This method implementation was left in
DocumentMarkerListEditor in https://codereview.chromium.org/2829543002
to make that patch smaller. This patch moves it to its final location.

BUG=707867
==========

to

==========
Move SpellCheckMarkerListImpl::Add() implementation from DMLEditor.cpp

Move SpellCheckMarkerListImpl::Add() from DocumentMarkerListEditor.cpp to
SpellCheckMarkerListImpl.cpp. This method implementation was left in
DocumentMarkerListEditor in https://codereview.chromium.org/2829543002
to make that patch smaller. This patch moves it to its final location.

BUG=707867

Review-Url: https://codereview.chromium.org/2851633003
Cr-Commit-Position: refs/heads/master@{#471229}
Committed:
https://chromium.googlesource.com/chromium/src/+/01d3e7ab39cb3238de4950601fb9...
==========

[commit-bot: I haz the power, 2017-05-12 05:36:02]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/01d3e7ab39cb3238de4950601fb9...