third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp - Issue 2829543002: [DMC #5] Add SpellCheckMarkerListImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp

Issue 2829543002: [DMC #5] Add SpellCheckMarkerListImpl (Closed)

Patch Set: Remove comment about RemoveMarkersUnderWords() being SpellCheckMarkerListImpl-specific (it's not ye… Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp ('k') | third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp b/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp

index bc83f4d1568c036d293a15a830e9fd0e4cd66693..aa0cd56d6eb13cb78ed0719fe7fcb4333f958e55 100644

--- a/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp

@@ -17,8 +17,7 @@ void GenericDocumentMarkerListImpl::Add(DocumentMarker* marker) {

switch (marker->GetType()) {

case DocumentMarker::kSpelling:

case DocumentMarker::kGrammar:

- DocumentMarkerListEditor::AddMarkerAndMergeOverlapping(&markers_, marker);

- return;

+ NOTREACHED();

case DocumentMarker::kTextMatch:

DocumentMarkerListEditor::AddMarkerWithoutMergingOverlapping(&markers_,

marker);