Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(22)

Issue 2829333002: [Home] Fix invalid state crash (Closed)

Created:
2 years, 2 months ago by mdjones
Modified:
2 years, 2 months ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Fix invalid state crash When creating the settle animation for the bottom sheet, the input value is used instead of the caches target state. This should prevent a race condition where the target state is set to "none" before the animation completes, thus avoiding an invalid state. BUG=709034 Review-Url: https://codereview.chromium.org/2829333002 Cr-Commit-Position: refs/heads/master@{#466498} Committed: https://chromium.googlesource.com/chromium/src/+/bca2fafc03e60ce6ccb166ecc0ecda0e481fa05f

Patch Set 1 #

Patch Set 2 : revert cancel changes #

Messages

Total messages: 8 (4 generated)
mdjones
ptal
2 years, 2 months ago (2017-04-21 22:25:12 UTC) #2
Theresa
lgtm
2 years, 2 months ago (2017-04-21 22:44:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829333002/20001
2 years, 2 months ago (2017-04-21 23:23:40 UTC) #5
commit-bot: I haz the power
2 years, 2 months ago (2017-04-21 23:58:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bca2fafc03e60ce6ccb166ecc0ec...

Powered by Google App Engine
This is Rietveld 408576698