🏠 Polish bottom sheet content transitions

[Home] Polish bottom sheet content transitions

This change adds animation when transitioning between bottom sheet
content. The existing view is faded out completely before the new
view is faded in. The animation is applied to both the sheet content
and the toolbar view.

Notably, the onContentChanged() event is now called when the
transition animation has finished instead of immediately when
showContent(...) is called.

BUG=702717
Review-Url: https://codereview.chromium.org/2839673002
Cr-Original-Commit-Position: refs/heads/master@{#466780}
Committed: https://chromium.googlesource.com/chromium/src/+/419509cbf0ac3a8a8595b3ce9e56daf75e5c2f0c
Review-Url: https://codereview.chromium.org/2839673002
Cr-Commit-Position: refs/heads/master@{#467589}
Committed: https://chromium.googlesource.com/chromium/src/+/a3113f3049092c40df4181b98e960785eaadcfb9

[mdjones, 2017-04-24 16:59:23]

Description was changed from

==========
[Home] Polish bottom sheet content transitions

This change adds animation when transitioning between bottom sheet
content. The existing view is faded out completely before the new
view is faded in. The animation is applied to both the sheet content
and the toolbar view.

Notably, the onContentChanged() event is now called when the
transition animation has finished instead of immediately when
showContent(...) is called.

BUG=702717
==========

to

==========
[Home] Polish bottom sheet content transitions

This change adds animation when transitioning between bottom sheet
content. The existing view is faded out completely before the new
view is faded in. The animation is applied to both the sheet content
and the toolbar view.

Notably, the onContentChanged() event is now called when the
transition animation has finished instead of immediately when
showContent(...) is called.

BUG=702717
==========

[mdjones, 2017-04-24 17:56:35]

mdjones@chromium.org changed reviewers:
+ twellington@chromium.org

[mdjones, 2017-04-24 17:56:36]

ptal

[Theresa, 2017-04-24 20:50:35]

lgtm

[mdjones, 2017-04-24 20:51:30]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2017-04-24 20:52:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 21:42:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493067090157560, "parent_rev":
"da95b744392115e21f8e9820493eb47bb27bce9f", "commit_rev":
"419509cbf0ac3a8a8595b3ce9e56daf75e5c2f0c"}

[commit-bot: I haz the power, 2017-04-24 21:42:48]

Description was changed from

==========
[Home] Polish bottom sheet content transitions

This change adds animation when transitioning between bottom sheet
content. The existing view is faded out completely before the new
view is faded in. The animation is applied to both the sheet content
and the toolbar view.

Notably, the onContentChanged() event is now called when the
transition animation has finished instead of immediately when
showContent(...) is called.

BUG=702717
==========

to

==========
[Home] Polish bottom sheet content transitions

This change adds animation when transitioning between bottom sheet
content. The existing view is faded out completely before the new
view is faded in. The animation is applied to both the sheet content
and the toolbar view.

Notably, the onContentChanged() event is now called when the
transition animation has finished instead of immediately when
showContent(...) is called.

BUG=702717

Review-Url: https://codereview.chromium.org/2839673002
Cr-Commit-Position: refs/heads/master@{#466780}
Committed:
https://chromium.googlesource.com/chromium/src/+/419509cbf0ac3a8a8595b3ce9e56...
==========

[commit-bot: I haz the power, 2017-04-24 21:42:49]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/419509cbf0ac3a8a8595b3ce9e56...

[perezju, 2017-04-26 11:13:22]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2838313003/ by perezju@chromium.org.

The reason for reverting is: Appears to be causing multiple
chrome_public_test_apk failures on Marshmallow 64 bit Tester.
crbug.com/715336.

[mdjones, 2017-04-27 00:02:47]

Description was changed from

==========
[Home] Polish bottom sheet content transitions

This change adds animation when transitioning between bottom sheet
content. The existing view is faded out completely before the new
view is faded in. The animation is applied to both the sheet content
and the toolbar view.

Notably, the onContentChanged() event is now called when the
transition animation has finished instead of immediately when
showContent(...) is called.

BUG=702717

Review-Url: https://codereview.chromium.org/2839673002
Cr-Commit-Position: refs/heads/master@{#466780}
Committed:
https://chromium.googlesource.com/chromium/src/+/419509cbf0ac3a8a8595b3ce9e56...
==========

to

==========
[Home] Polish bottom sheet content transitions

This change adds animation when transitioning between bottom sheet
content. The existing view is faded out completely before the new
view is faded in. The animation is applied to both the sheet content
and the toolbar view.

Notably, the onContentChanged() event is now called when the
transition animation has finished instead of immediately when
showContent(...) is called.

BUG=702717

Review-Url: https://codereview.chromium.org/2839673002
Cr-Commit-Position: refs/heads/master@{#466780}
Committed:
https://chromium.googlesource.com/chromium/src/+/419509cbf0ac3a8a8595b3ce9e56...
==========

[mdjones, 2017-04-27 00:04:29]

The flaky tests are due to the bottom sheet content being set after the initial
animation ends. I added some logic to immediately end the animation if there was
no prior content. ptal

[Theresa, 2017-04-27 00:05:19]

lgtm

[mdjones, 2017-04-27 00:41:42]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2017-04-27 00:42:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 05:04:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493253702387830,
"parent_rev": "488d76c52ca6b91e1287ad21608c3bca20d016cb", "commit_rev":
"a3113f3049092c40df4181b98e960785eaadcfb9"}

[commit-bot: I haz the power, 2017-04-27 05:06:06]

Description was changed from

==========
[Home] Polish bottom sheet content transitions

This change adds animation when transitioning between bottom sheet
content. The existing view is faded out completely before the new
view is faded in. The animation is applied to both the sheet content
and the toolbar view.

Notably, the onContentChanged() event is now called when the
transition animation has finished instead of immediately when
showContent(...) is called.

BUG=702717

Review-Url: https://codereview.chromium.org/2839673002
Cr-Commit-Position: refs/heads/master@{#466780}
Committed:
https://chromium.googlesource.com/chromium/src/+/419509cbf0ac3a8a8595b3ce9e56...
==========

to

==========
[Home] Polish bottom sheet content transitions

This change adds animation when transitioning between bottom sheet
content. The existing view is faded out completely before the new
view is faded in. The animation is applied to both the sheet content
and the toolbar view.

Notably, the onContentChanged() event is now called when the
transition animation has finished instead of immediately when
showContent(...) is called.

BUG=702717

Review-Url: https://codereview.chromium.org/2839673002
Cr-Original-Commit-Position: refs/heads/master@{#466780}
Committed:
https://chromium.googlesource.com/chromium/src/+/419509cbf0ac3a8a8595b3ce9e56...
Review-Url: https://codereview.chromium.org/2839673002
Cr-Commit-Position: refs/heads/master@{#467589}
Committed:
https://chromium.googlesource.com/chromium/src/+/a3113f3049092c40df4181b98e96...
==========

[commit-bot: I haz the power, 2017-04-27 05:06:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a3113f3049092c40df4181b98e96...