Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2846883003: [Home] Fix solid-color tab switcher toolbar (Closed)

Created:
3 years, 7 months ago by mdjones
Modified:
3 years, 7 months ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Fix solid-color tab switcher toolbar In order to make transitions between bottom sheet contents look good, a background color was set on the toolbar container. This causes an issue in the tab switcher which needs the toolbar to be transparent. This change conditionally sets the background color of the toolbar container while the content transition animation is running. BUG=702717 Review-Url: https://codereview.chromium.org/2846883003 Cr-Commit-Position: refs/heads/master@{#467770} Committed: https://chromium.googlesource.com/chromium/src/+/cb16fb047dd38b28b4096dc8ad29f0fe9fb03732

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/android/java/res/layout/bottom_control_container.xml View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java View 2 chunks +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
mdjones
ptal
3 years, 7 months ago (2017-04-27 16:45:33 UTC) #2
Theresa
lgtm
3 years, 7 months ago (2017-04-27 17:34:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846883003/1
3 years, 7 months ago (2017-04-27 18:46:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846883003/1
3 years, 7 months ago (2017-04-27 18:50:54 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 20:36:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cb16fb047dd38b28b4096dc8ad29...

Powered by Google App Engine
This is Rietveld 408576698