Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2843263003: Patch overlay panel event stream internally (Closed)

Created:
3 years, 7 months ago by mdjones
Modified:
3 years, 7 months ago
Reviewers:
Khushal
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch overlay panel event stream internally This change adds logic inside the OverlayPanelEventFilter to make sure that at least one down event is being passed to the internal gesture detector before a stream starts. BUG=715183 Review-Url: https://codereview.chromium.org/2843263003 Cr-Commit-Position: refs/heads/master@{#467768} Committed: https://chromium.googlesource.com/chromium/src/+/5cf597d4e4e4409bf219d499ff00972fa60fcf0c

Patch Set 1 #

Patch Set 2 : variables go at the top #

Total comments: 2

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/OverlayPanelEventFilter.java View 1 2 2 chunks +11 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
mdjones
ptal
3 years, 7 months ago (2017-04-27 17:07:59 UTC) #2
Khushal
https://codereview.chromium.org/2843263003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/OverlayPanelEventFilter.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/OverlayPanelEventFilter.java (right): https://codereview.chromium.org/2843263003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/OverlayPanelEventFilter.java#newcode339 chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/OverlayPanelEventFilter.java:339: super.onTouchEventInternal(down); set mFilterHadDownEvent to true in this block as ...
3 years, 7 months ago (2017-04-27 17:18:00 UTC) #3
mdjones
https://codereview.chromium.org/2843263003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/OverlayPanelEventFilter.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/OverlayPanelEventFilter.java (right): https://codereview.chromium.org/2843263003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/OverlayPanelEventFilter.java#newcode339 chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/OverlayPanelEventFilter.java:339: super.onTouchEventInternal(down); On 2017/04/27 17:18:00, Khushal wrote: > set mFilterHadDownEvent ...
3 years, 7 months ago (2017-04-27 17:22:32 UTC) #4
Khushal
lgtm and good luck!
3 years, 7 months ago (2017-04-27 17:29:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843263003/40001
3 years, 7 months ago (2017-04-27 18:46:52 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 20:31:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5cf597d4e4e4409bf219d499ff00...

Powered by Google App Engine
This is Rietveld 408576698