[Home] Infobars appear more often

[Home] Infobars appear more often

This change modifies the behavior of infobars when the user scrolls
a web page. Infobars now have the following behavior:

- No longer only show near the top of the web page.
- Can now appear if the user is scrolled to the middle of the page.
- Closely follow the behavior of the toolbar but is not synced to it.

BUG=587583
Review-Url: https://codereview.chromium.org/2844893002
Cr-Commit-Position: refs/heads/master@{#470080}
Committed: https://chromium.googlesource.com/chromium/src/+/5f3484435c495bdc313e8cf1628a200b927f1209

[mdjones, 2017-05-05 21:53:23]

mdjones@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[mdjones, 2017-05-05 21:53:24]

ptal

[gone, 2017-05-08 17:01:54]

lgtm

https://codereview.chromium.org/2844893002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java
(right):

https://codereview.chromium.org/2844893002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java:193:
// Tracks the previous event's scroll offset to determine if a scroll is up or
down.
javadoc syntax instead

[mdjones, 2017-05-08 18:13:06]

https://codereview.chromium.org/2844893002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java
(right):

https://codereview.chromium.org/2844893002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java:193:
// Tracks the previous event's scroll offset to determine if a scroll is up or
down.
On 2017/05/08 17:01:53, slow (dfalcantara) wrote:
> javadoc syntax instead

Done.

[mdjones, 2017-05-08 18:14:41]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2017-05-08 18:14:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2844893002/#ps20001
(title: "javadocize")

[commit-bot: I haz the power, 2017-05-08 18:15:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 19:46:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494267281363530,
"parent_rev": "2519704f857e56660e21c7309f8fdd18c86a8f99", "commit_rev":
"5f3484435c495bdc313e8cf1628a200b927f1209"}

[commit-bot: I haz the power, 2017-05-08 19:47:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494267281363530,
"parent_rev": "2519704f857e56660e21c7309f8fdd18c86a8f99", "commit_rev":
"5f3484435c495bdc313e8cf1628a200b927f1209"}

[commit-bot: I haz the power, 2017-05-08 19:47:30]

Description was changed from

==========
[Home] Infobars appear more often

This change modifies the behavior of infobars when the user scrolls
a web page. Infobars now have the following behavior:

- No longer only show near the top of the web page.
- Can now appear if the user is scrolled to the middle of the page.
- Closely follow the behavior of the toolbar but is not synced to it.

BUG=587583
==========

to

==========
[Home] Infobars appear more often

This change modifies the behavior of infobars when the user scrolls
a web page. Infobars now have the following behavior:

- No longer only show near the top of the web page.
- Can now appear if the user is scrolled to the middle of the page.
- Closely follow the behavior of the toolbar but is not synced to it.

BUG=587583

Review-Url: https://codereview.chromium.org/2844893002
Cr-Commit-Position: refs/heads/master@{#470080}
Committed:
https://chromium.googlesource.com/chromium/src/+/5f3484435c495bdc313e8cf1628a...
==========

[commit-bot: I haz the power, 2017-05-08 19:47:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5f3484435c495bdc313e8cf1628a...