Remove scroll layer ids from scrollbar layers

Remove scroll layer ids from scrollbar layers

This patch removes scroll layer ids from scrollbar layers so scrollbars only
track the scrolling element id. The big changes in this patch are:
1) ScrollbarLayerInterface no longer has a scroll_layer_id and instead just
uses scroll_element_id. SetScrollInfo has been renamed SetScrollElementId.
2) Similarly, ScrollbarLayerImplBase no longer has a scroll_layer_id and
SetScrollInfo has been renamed SetScrollElementId.
3) Regrettably, two instances of LayerIdByElementId have been added in
RegisterScrollbar and CanScrollOrientation. These uses of LayerIdByElementId
require a 1:1 mapping between layers and element ids which is not necessary.
TODOs have been added to remove these.

This patch also fixes a bug in ScrollbarLayerImplBase::SetScrollLayerId where
scroll_element_id was compared to itself instead of scroll_element_id_.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2827163005
Cr-Commit-Position: refs/heads/master@{#466091}
Committed: https://chromium.googlesource.com/chromium/src/+/75a6cc514e06cd92ccf0689898e15c6d2b6fca16

[pdr., 2017-04-20 02:53:15]

pdr@chromium.org changed reviewers:
+ enne@chromium.org, wkorman@chromium.org

[pdr., 2017-04-20 02:53:20]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 02:53:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 05:04:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 05:04:12]

Dry run: This issue passed the CQ dry run.

[wkorman, 2017-04-20 17:53:47]

lgtm

https://codereview.chromium.org/2827163005/diff/1/cc/layers/scrollbar_layer_i...
File cc/layers/scrollbar_layer_impl_base.cc (right):

https://codereview.chromium.org/2827163005/diff/1/cc/layers/scrollbar_layer_i...
cc/layers/scrollbar_layer_impl_base.cc:46: if (scroll_element_id_ ==
scroll_element_id)
Can we add a unit test that would have caught this?

[pdr., 2017-04-20 18:04:40]

On 2017/04/20 at 17:53:47, wkorman wrote:
> lgtm
> 
>
https://codereview.chromium.org/2827163005/diff/1/cc/layers/scrollbar_layer_i...
> File cc/layers/scrollbar_layer_impl_base.cc (right):
> 
>
https://codereview.chromium.org/2827163005/diff/1/cc/layers/scrollbar_layer_i...
> cc/layers/scrollbar_layer_impl_base.cc:46: if (scroll_element_id_ ==
scroll_element_id)
> Can we add a unit test that would have caught this?

A lot of tests crash because of it. These tests didn't fail before because of
the other conditional, but with the other conditional removed the bug became
apparent.

[enne (OOO), 2017-04-20 18:44:39]

Description was changed from

==========
Remove scroll layer ids from scrollbar layers

This patch removes scroll layer ids from scrollbar layers so scrollbars only
track the scrolling element id. The big changes in this patch are:
1) ScrollbarLayerInterface no longer has a scroll_layer_id and instead just
uses scroll_element_id. SetScrollInfo has been renamed SetScrollElementId.
2) Similarly, ScrollbarLayerImplBase no longer has a scroll_layer_id and
SetScrollInfo has been renamed SetScrollElementId.
3) Regretabally, two instances of LayerIdByElementId have been added in
RegisterScrollbar and CanScrollOrientation. These uses of LayerIdByElementId
require a 1:1 mapping between layers and element ids which is not necessary.
TODOs have been added to remove these.

This patch also fixes a bug in ScrollbarLayerImplBase::SetScrollLayerId where
scroll_element_id was compared to itself instead of scroll_element_id_.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove scroll layer ids from scrollbar layers

This patch removes scroll layer ids from scrollbar layers so scrollbars only
track the scrolling element id. The big changes in this patch are:
1) ScrollbarLayerInterface no longer has a scroll_layer_id and instead just
uses scroll_element_id. SetScrollInfo has been renamed SetScrollElementId.
2) Similarly, ScrollbarLayerImplBase no longer has a scroll_layer_id and
SetScrollInfo has been renamed SetScrollElementId.
3) Regrettably, two instances of LayerIdByElementId have been added in
RegisterScrollbar and CanScrollOrientation. These uses of LayerIdByElementId
require a 1:1 mapping between layers and element ids which is not necessary.
TODOs have been added to remove these.

This patch also fixes a bug in ScrollbarLayerImplBase::SetScrollLayerId where
scroll_element_id was compared to itself instead of scroll_element_id_.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[enne (OOO), 2017-04-20 18:51:22]

This is great! lgtm

[pdr., 2017-04-20 19:13:04]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-04-20 19:13:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 19:21:18]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492715584417720, "parent_rev":
"da4acf3e0dc7db9b53f7a75e63ba95553f31d194", "commit_rev":
"75a6cc514e06cd92ccf0689898e15c6d2b6fca16"}

[commit-bot: I haz the power, 2017-04-20 19:21:35]

Description was changed from

==========
Remove scroll layer ids from scrollbar layers

This patch removes scroll layer ids from scrollbar layers so scrollbars only
track the scrolling element id. The big changes in this patch are:
1) ScrollbarLayerInterface no longer has a scroll_layer_id and instead just
uses scroll_element_id. SetScrollInfo has been renamed SetScrollElementId.
2) Similarly, ScrollbarLayerImplBase no longer has a scroll_layer_id and
SetScrollInfo has been renamed SetScrollElementId.
3) Regrettably, two instances of LayerIdByElementId have been added in
RegisterScrollbar and CanScrollOrientation. These uses of LayerIdByElementId
require a 1:1 mapping between layers and element ids which is not necessary.
TODOs have been added to remove these.

This patch also fixes a bug in ScrollbarLayerImplBase::SetScrollLayerId where
scroll_element_id was compared to itself instead of scroll_element_id_.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove scroll layer ids from scrollbar layers

This patch removes scroll layer ids from scrollbar layers so scrollbars only
track the scrolling element id. The big changes in this patch are:
1) ScrollbarLayerInterface no longer has a scroll_layer_id and instead just
uses scroll_element_id. SetScrollInfo has been renamed SetScrollElementId.
2) Similarly, ScrollbarLayerImplBase no longer has a scroll_layer_id and
SetScrollInfo has been renamed SetScrollElementId.
3) Regrettably, two instances of LayerIdByElementId have been added in
RegisterScrollbar and CanScrollOrientation. These uses of LayerIdByElementId
require a 1:1 mapping between layers and element ids which is not necessary.
TODOs have been added to remove these.

This patch also fixes a bug in ScrollbarLayerImplBase::SetScrollLayerId where
scroll_element_id was compared to itself instead of scroll_element_id_.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2827163005
Cr-Commit-Position: refs/heads/master@{#466091}
Committed:
https://chromium.googlesource.com/chromium/src/+/75a6cc514e06cd92ccf0689898e1...
==========

[commit-bot: I haz the power, 2017-04-20 19:21:38]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/75a6cc514e06cd92ccf0689898e1...